Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if globalrechitsanalyze is in the sequence before modifying it #4556

Merged

Conversation

mark-grimes
Copy link

If validation is configured it deletes globalrechitsanalyze if the pileup is greater than 30. If DQM is also run it tries to modify globalrechitsanalyze and hence throws an exception. This just adds a check to see if globalrechitsanalyze exists before modifying it.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2014

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Check if globalrechitsanalyze is in the sequence before modifying it

It involves the following packages:

SLHCUpgradeSimulations/Configuration

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ghost ghost modified the milestone: Next CMSSW_6_2_X_SLHC Jul 9, 2014
@mark-grimes
Copy link
Author

merge

Tested all scenarios with 0 pileup to make sure old behaviour is fine. Tested Shashlik at 140 pileup to make sure the error is fixed.

cmsbuild added a commit that referenced this pull request Jul 10, 2014
Check if globalrechitsanalyze is in the sequence before modifying it
@cmsbuild cmsbuild merged commit 2dc665e into cms-sw:CMSSW_6_2_X_SLHC Jul 10, 2014
@mark-grimes mark-grimes deleted the checkIfRecHitAnalyzeTakenOut branch July 11, 2014 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants