Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_1_X] Update to relval_gpu.pyfor Alpaka and Pixel Triplets Alpaka Workflows #45958

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

AdrianoDee
Copy link
Contributor

@AdrianoDee AdrianoDee commented Sep 9, 2024

Backport of #45694 (with the exception of a comment that will anyway disappear soon) and #45963 (a fix) to 14_1_X.

This is useful because it allows to run 2024 Alpaka wfs in the PR testing, meaning we test also the Alpaka HLT.

- removing CUDA wfs
- adding triplets
- fixing Phase2 DQM GPUvsGPU (no raw)
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2024

A new Pull Request was created by @AdrianoDee for CMSSW_14_1_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)
  • DQM/SiPixelHeterogeneous (dqm)
  • RecoTracker/Configuration (reconstruction)

@AdrianoDee, @antoniovagnerini, @cmsbuild, @jfernan2, @kskovpen, @mandrenguyen, @miquork, @nothingface0, @rvenditti, @srimanob, @subirsarkar, @sunilUIET, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanFSchulte, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @fabiocos, @felicepantaleo, @fioriNTU, @gpetruc, @idebruyn, @jandrea, @makortel, @missirol, @mmusich, @mtosi, @rovere, @slomeo, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2024

cms-bot internal usage

@AdrianoDee AdrianoDee marked this pull request as ready for review September 9, 2024 10:55
@AdrianoDee
Copy link
Contributor Author

enable gpu

@AdrianoDee
Copy link
Contributor Author

test parameters:

  • workflows = 12834.406, 12834.402, 29834.402, 29634.406
  • workflows_gpu = 12834.406, 12834.402, 12834.403, 29834.402, 29634.406, 29834.403, 29634.496, 12834.496
  • relvals_opt = --what upgrade
  • relvals_opt_gpu = --what upgrade

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2024

-1

Failed Tests: RelVals-GPU
Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0c426/41407/summary.html
COMMIT: bcb80e4
CMSSW: CMSSW_14_1_X_2024-09-09-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45958/41407/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-GPU

  • 29834.40329834.403_TTbar_14TeV+2026D110PU_Patatrack_PixelOnlyAlpaka_Validation/step4_TTbar_14TeV+2026D110PU_Patatrack_PixelOnlyAlpaka_Validation.log

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3434917
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3434888
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 195 log files, 166 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@AdrianoDee
Copy link
Contributor Author

please test

@AdrianoDee
Copy link
Contributor Author

please abort

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2024

Pull request #45958 was updated. @AdrianoDee, @antoniovagnerini, @cmsbuild, @jfernan2, @kskovpen, @mandrenguyen, @miquork, @nothingface0, @rvenditti, @srimanob, @subirsarkar, @sunilUIET, @syuvivida, @tjavaid can you please check and sign again.

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0c426/41418/summary.html
COMMIT: 01c3101
CMSSW: CMSSW_14_1_X_2024-09-09-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45958/41418/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 78 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3434917
  • DQMHistoTests: Total failures: 4598
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3430299
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 195 log files, 166 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 1
  • DQMHistoTests: Total histograms compared: 0
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 0
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 0 log files, 0 edm output root files, 1 DQM output files

@jfernan2
Copy link
Contributor

+1

@AdrianoDee
Copy link
Contributor Author

+pdmv

@AdrianoDee
Copy link
Contributor Author

Note to @cms-sw/dqm-l2: the fix in #45963 should go in first. Thanks.

@antoniovagnerini
Copy link

+1

@mmusich
Copy link
Contributor

mmusich commented Sep 16, 2024

@cms-sw/upgrade-l2 please take a look / sign

@@ -33,11 +33,15 @@ The offsets currently in use are:
* 0.402: Alpaka, pixel only quadruplets, portable
* 0.403: Alpaka, pixel only quadruplets, portable vs. CPU validation
* 0.404: Alpaka, pixel only quadruplets, portable profiling
* 0.406: Alpaka, pixel only triplets, portable
* 0.407: Alpaka, pixel only triplets, portable vs. CPU validation
* 0.407: Alpaka, pixel only triplets, portable profiling
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo? Also in the master. Please fix in the follow up PR.

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f120b86 into cms-sw:CMSSW_14_1_X Sep 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants