Run3-hcx361 Make Era dependent ZDC geometry - backport #45511

[bsunanda]

PR description:

Make Era dependent ZDC geometry - backport #45511

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[bsunanda]

@cmsbuild Please test

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_14_1_X.

It involves the following packages:

• CalibCalorimetry/HcalPlugins (alca)
• CondFormats/HcalObjects (db, alca)
• CondTools/Geometry (db)
• Configuration/Geometry (geometry, upgrade)
• Geometry/CaloGeometry (geometry)
• Geometry/CaloTopology (geometry)
• Geometry/ForwardGeometry (geometry)
• Geometry/HcalCommonData (geometry)
• Geometry/HcalTowerAlgo (geometry)
• Geometry/Records (geometry)
• HLTrigger/Configuration (hlt)
• SimCalorimetry/HcalSimProducers (simulation)
• SimCalorimetry/HcalTrigPrimProducers (l1)

@Dr15Jones, @Martin-Grunewald, @aloeliger, @bsunanda, @civanch, @consuegs, @epalencia, @francescobrivio, @kpedro88, @makortel, @mdhildreth, @mmusich, @perrotta, @saumyaphor4252, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@JanChyczynski, @Martin-Grunewald, @PonIlya, @ReyerBand, @abdoulline, @argiro, @fabiocos, @mariadalfonso, @martinamalberti, @missirol, @mmusich, @rchatter, @rovere, @rsreds, @sameasy, @seemasharmafnal, @silviodonato, @slomeo, @thomreis, @tocheng, @vargasa, @wang0jin, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Run3-hcx360 Make ZDC geometry varying with ERAs  #45511

[cmsbuild]

cms-bot internal usage

[mmusich]

backport of #45511

[mandrenguyen]

ZDV = ZDC ?

[cmsbuild]

+1

Size: This PR adds an extra 44KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-192073/41548/summary.html
COMMIT: 142d90e
CMSSW: CMSSW_14_1_X_2024-09-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46011/41548/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 49 lines to the logs
• Reco comparison results: 24510 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3330894
• DQMHistoTests: Total failures: 48945
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3281929
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -1.304 KiB( 43 files compared)
• DQMHistoSizes: changed ( 250202.181 ): 0.182 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): -0.127 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 7.3 ): -0.120 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 8.0 ): -1.239 KiB SiStrip/MechanicalView
• Checked 191 log files, 161 edm output root files, 44 DQM output files
• TriggerResults: found differences in 6 / 42 workflows

[mandrenguyen]

urgent
Needed to build 14_1_0 for heavy-ion data taking

[bsunanda]

@aloeliger, @civanch, @consuegs, @epalencia, @francescobrivio, @mmusich, @perrotta, @saumyaphor4252, @srimanob Please approve this back port

[cmsbuild]

Pull request #46011 was updated. @Dr15Jones, @Martin-Grunewald, @aloeliger, @bsunanda, @civanch, @cmsbuild, @consuegs, @epalencia, @francescobrivio, @kpedro88, @makortel, @mdhildreth, @mmusich, @perrotta, @saumyaphor4252, @srimanob, @subirsarkar can you please check and sign again.

[bsunanda]

@aloeliger, @civanch, @consuegs, @epalencia, @srimanob Please approve this PR - it is urgent

[mmusich]

can this backport include directly also the commits of #46033 ?

[srimanob]

+Upgrade

[bsunanda]

+geometry

[bsunanda]

@aloeliger, @civanch, @consuegs, @epalencia Please approve this PR

[bsunanda]

#46033 is still not approved and it can be backported once this PR is merged. I urgently seek merging of this PR

[civanch]

+1

[mandrenguyen]

+1

[mandrenguyen]

merge
bypassing L1 in the interest of time, but they signed the master version

[aloeliger]

Apologies, that's fine by us.

[abdoulline]

Now the RelVal results are not available anymore, so not clear which way (only rndm ?) the results were affected at the DIGI level...
🤔

[kpedro88]

@abdoulline changes in the SIM-level geometry lead to changes in random number calls, resulting in statistical fluctuations.

[abdoulline]

@abdoulline changes in the SIM-level geometry lead to changes in random number calls, resulting in statistical fluctuations.

I thought it's about preparatory work, not yet any Geometry changes deployed... 🤔
If I remember it right, all the changes came at DIGI level (because of HcalDigitizer.cc modifications?) and I've even answered in a similar way to Andrea Perrotta some time ago in another PR chat, when was asked about massive differences.
But I'm just not sure anymore if there were only these random changes...