Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Era_Run3_2024 modifier to simOmtfDigis, to use OMTF 2024 config (14_1_X) #46015

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

kbunkow
Copy link
Contributor

@kbunkow kbunkow commented Sep 17, 2024

L1Trigger/L1TMuonOverlapPhase1/python/simOmtfDigis_cfi.py: added parameters configXMLFile and patternsXMLFile corresponding to the 2024 OMTF firmware to the stage2L1Trigger_2024 era modifier. This is needed since there are problems with uploading the 2024 OMTF params to the condDB.

The files
L1Trigger/L1TMuon/data/omtf_config/hwToLogicLayer_0x0009.xml
L1Trigger/L1TMuon/data/omtf_config/Patterns_ExtraplMB1nadMB2SimplifiedFP_t17_classProb17_recalib2_minDP0_v3.xml
are in the CMSSW_DATA.

PR description:

Up to now, the OMTF emulator configuration parameters were stored in the condDB. The new parameters were uploaded to the condDB with the use of the "manual o2o" procedure. Unfortunately, the knowledge of how to execute this procedure was lost, and despite a few trials, the upload of the OMTF params corresponding to the firmware deployed at P5 in March of 2024 was unsuccessful. Therefore, with this PR, the emulator will be configured from the appropriate XML files, provided the Era Run3_2024 is defined for the job.
This will fix the data-emulator mismatches present in the DQM since the beginning of the 2024 pp run. Besides, will ensure the upcoming 2024 MC production will use the 2024 OMTF algorithm version.

PR validation:

The PR was validated by running the L1T DQM on one file from run 385422. The data-to-emulator mismatches for the OMTF are at the level of 0.5%, which is the expected level when the OMTF is properly configured.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport of #45984.

L1Trigger/L1TMuonOverlapPhase1/python/simOmtfDigis_cfi.py:
added parameters configXMLFile and patternsXMLFile corresponding to the 2024 OMTF firmware to the stage2L1Trigger_2024 era modifier.
This is needed since there are problems with uploading the 2024 OMTF params to the condDB.
backport of cms-sw@c7410d8
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 17, 2024

A new Pull Request was created by @kbunkow for CMSSW_14_1_X.

It involves the following packages:

  • L1Trigger/L1TMuonOverlapPhase1 (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @dinyar, @eyigitba, @missirol, @mmusich, @thomreis this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 17, 2024

cms-bot internal usage

@aloeliger
Copy link
Contributor

backport of #45984

@aloeliger
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8608ea/41552/summary.html
COMMIT: 785d91e
CMSSW: CMSSW_14_1_X_2024-09-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46015/41552/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3330894
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3330871
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c527d2c into cms-sw:CMSSW_14_1_X Sep 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants