-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
72x taus sqlite hook #4686
72x taus sqlite hook #4686
Conversation
A new Pull Request was created by @jpavel (Pavel Jez) for CMSSW_7_2_X. 72x taus sqlite hook It involves the following packages: RecoTauTag/Configuration @nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
-1 >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-07-16-0200/src/GeneratorInterface/AMPTInterface/src/art1f.f >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-07-16-0200/src/GeneratorInterface/AMPTInterface/src/hijing1.383_ampt.f >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-07-16-0200/src/GeneratorInterface/AMPTInterface/src/hipyset1.35.f >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-07-16-0200/src/GeneratorInterface/AMPTInterface/src/linana.f /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-07-16-0200/src/GeneratorInterface/RivetInterface/plugins/RivetHarvesting.cc: In constructor 'RivetHarvesting::RivetHarvesting(const edm::ParameterSet&)': /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-07-16-0200/src/GeneratorInterface/RivetInterface/plugins/RivetHarvesting.cc:48:30: error: 'CmpAnaHandle' was not declared in this scope const std::set< AnaHandle, CmpAnaHandle > & analyses = _analysisHandler.analyses(); ^ /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-07-16-0200/src/GeneratorInterface/RivetInterface/plugins/RivetHarvesting.cc:48:43: error: template argument 2 is invalid const std::set< AnaHandle, CmpAnaHandle > & analyses = _analysisHandler.analyses(); ^ you can see the results of the tests here: |
@cmsbuild Let's get jenkins rerun. Although the IB used, CMSSW_7_2_X_2014-07-16-0200, is listed to have no build errors (has other errors/warnings) I encounter the error above locally as well. The error has nothing to do with this PR. The PR complies fine with a more recent IB - I checked CMSSW_7_2_X_2014-07-17-0600. Please rerun tests. |
Checking... The PR is identical to (part of) #4585 that was causing some unexplained performance changes initially (later just dropped the problematic part). |
+1 First I was testing with an older IB, CMSSW_7_2_X_2014-07-17-0600, and the jobs (for the IB, not even the IB+PR) were running forever. I did not investigate given the newer IB was fine. |
@jpavel how do actually check the new functionality works properly? Can you add (in another PR) some testing configuration file in test/ ? |
Fine, there should be a better way but I guess I would have to dig it up if suggesting it, will see. |
@StoyanStoynev - yes I missed that one (and also similar case for antiElectron). You are right about the code repetition, we will try to solve it in the future. Also, I updated the PR description with the recipe of how to test the new feature. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). |
RecoTauTag -- 72x taus sqlite hook
RecoTauTag -- 72x taus sqlite hook
The hooks for the sqlite file reading that have been originally in #4585. There have been reported differences in anti-electron config, that have been caused by typo in config files and fixed. The difference in isolation discriminators was not observed, so perhaps it have been fixed already.
This pull request does not change the RECO sequence at all, but adds new function to switch MVA input to a DB file
EDIT: to test new feature, simply add following lines to your config file