Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in reco to TGeo conversion #4727

Merged
merged 19 commits into from Jul 22, 2014
Merged

Conversation

alja
Copy link
Contributor

@alja alja commented Jul 21, 2014

  • import nodes in hierarchical way
  • make informative tooltips
  • add import of ecal ( hcal is in progress)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_7_1_X.

Improvements in reco to TGeo conversion

It involves the following packages:

Fireworks/Core
Fireworks/Geometry

@Dr15Jones, @cmsbuild, @alja, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #4727 was updated. @Dr15Jones, @cmsbuild, @alja, @nclopezo, @Degano, @ktf can you please check and sign again.

@alja
Copy link
Contributor Author

alja commented Jul 21, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Jul 22, 2014
Improvements in reco to TGeo conversion
@davidlange6 davidlange6 merged commit ec588db into cms-sw:CMSSW_7_1_X Jul 22, 2014
@alja alja deleted the recogeo2 branch May 11, 2017 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants