Fix handling of references and typedefs #4810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @wmtan for CMSSW_7_2_ROOT6_X. Fix handling of references and typedefs It involves the following packages: CommonTools/Utils @nclopezo, @monttj, @cmsbuild, @StoyanStoynev, @slava77, @vadler, @Degano can you please review it and eventually sign? Thanks. |
davidlt
added a commit
that referenced
this pull request
Jul 29, 2014
Fix handling of references and typedefs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes two ROOT6 specific errors in the CMS code that looks up functions for invocation,
One error was that, for references, the reference qualification was not properly removed. The second is that for types where the ROOT6 normalized name is a typedef (e.g Ulong64_t), an infinite regression could occur while attempting to remove typedefs. This pull request also removes an obsolete comment.
Please merge this pull request in a timely manner.