Fixed bug in BoostedJetMerger and made it a edm::stream::Producer #4967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoostedJetMerger had the wrong signature for beginJob and therefore that function was never called (caught by clang). However, neither beginJob nor endJob did anything so those methods were removed. In addition, it was safe to change BoostedJetMerger to an edm::stream::Producer and therefore become efficient when running with multiple threads.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_2_X. Fixed bug in BoostedJetMerger and made it a edm::stream::Producer It involves the following packages: PhysicsTools/PatUtils @nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks. |
|
Bypassing analysis. Complain if not ok. |
ktf
added a commit
that referenced
this pull request
Aug 16, 2014
…sPatUtils Fixed bug in BoostedJetMerger and made it a edm::stream::Producer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BoostedJetMerger had the wrong signature for beginJob and therefore
that function was never called (caught by clang). However, neither
beginJob nor endJob did anything so those methods were removed.
In addition, it was safe to change BoostedJetMerger to an
edm::stream::Producer and therefore become efficient when running
with multiple threads.