Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RecoTracker/dEdx package #4973

Merged
merged 14 commits into from
Aug 26, 2014
Merged

Conversation

quertenmont
Copy link
Contributor

Update RecoTracker/dEdx package in order to reduce the memory and CPU footprint,
Following suggestions by Vincenzo Innocente.
Also cleaned up the python and test directory.
Changes were tested in CMSSW_7_2_X_2014-08-06-0200 on standard RECO sequence.

Please include these changes in future 720_preX releases.
Thanks,

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @quertenmont (Loic Quertenmont) for CMSSW_7_2_X.

Update RecoTracker/dEdx package

It involves the following packages:

CalibTracker/SiStripChannelGain
DataFormats/TrackReco
RecoTracker/DeDx

@nclopezo, @cerminar, @cmsbuild, @diguida, @rcastello, @StoyanStoynev, @slava77, @Degano can you please review it and eventually sign? Thanks.
@ghellwig, @GiacomoSguazzoni, @rovere, @VinInn, @gpetruc, @cerati, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

-1
Tested at: 683f55c
When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

401.0 step1

runTheMatrix-results/401.0_TTbarNewMix+TTbarFSPU2+HARVESTFS/step1_TTbarNewMix+TTbarFSPU2+HARVESTFS.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID/step2_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID.log

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVEST+MINIAODMC/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVEST+MINIAODMC.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4973/634/summary.html

@VinInn
Copy link
Contributor

VinInn commented Aug 23, 2014

ping.
after the iteration with HLT this PR needs again signatures.

@quertenmont
Copy link
Contributor Author

+1
Can you please sign (before more conflict emerges) ?
Thanks
Loic

@ktf
Copy link
Contributor

ktf commented Aug 25, 2014

@slava77 @StoyanStoynev if you are ok, I'll bypass the rest of the signatures, are you looking into this?

@StoyanStoynev
Copy link
Contributor

I am not looking into this PR as Slava was checking it (intensively), he should say.

@slava77
Copy link
Contributor

slava77 commented Aug 25, 2014

I will take a look later today.

@slava77
Copy link
Contributor

slava77 commented Aug 26, 2014

+1

for #4973 0e4ff6d
tested with extended tests in CMSSW_7_2_X_2014-08-18-1400 (test area sign410)
the results are the same as in the previous cid, as expected.

@ktf
Copy link
Contributor

ktf commented Aug 26, 2014

Bypassing other signatures since they were either already signed or L2s is MIA. Complain if not ok.

ktf added a commit that referenced this pull request Aug 26, 2014
Update RecoTracker/dEdx package
@ktf ktf merged commit 5fe2bfc into cms-sw:CMSSW_7_2_X Aug 26, 2014
@quertenmont quertenmont deleted the DEDXUpdates branch August 27, 2014 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.