Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

62x_SLHC version of renamed script with a uniqe name to avoid clashes ... #5184

Merged
merged 1 commit into from
Sep 8, 2014

Conversation

apfeiffer1
Copy link
Contributor

... when installing/using as requested by Shahzad.
The clash was seen in 5.3.x when independent "make" processes tried to copy the scripts from both packages into the CMSSW bin/ area at the same time. As the content of the scripts is slightly different, I renamed both to be unique.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2014

A new Pull Request was created by @apfeiffer1 (Andreas Pfeiffer) for CMSSW_6_2_X_SLHC.

62x_SLHC version of renamed script with a uniqe name to avoid clashes ...

It involves the following packages:

CondTools/SiPixel
CondTools/SiStrip

@ggovi, @cmsbuild, @apfeiffer1, @nclopezo can you please review it and eventually sign? Thanks.
@dkotlins, @VinInn this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@apfeiffer1
Copy link
Contributor Author

+1

On Fri, Sep 5, 2014 at 11:32 AM, cmsbuild notifications@github.com wrote:

A new Pull Request was created by @apfeiffer1
https://github.com/apfeiffer1 (Andreas Pfeiffer) for CMSSW_6_2_X_SLHC.

62x_SLHC version of renamed script with a uniqe name to avoid clashes ...

It involves the following packages:

CondTools/SiPixel
CondTools/SiStrip

@ggovi https://github.com/ggovi, @cmsbuild https://github.com/cmsbuild,
@apfeiffer1 https://github.com/apfeiffer1, @nclopezo
https://github.com/nclopezo can you please review it and eventually
sign? Thanks.
@dkotlins https://github.com/dkotlins, @VinInn
https://github.com/VinInn this is something you requested to watch as
well.
You can sign-off by replying to this message having '+1' in the first line
of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.
@fratnikov https://github.com/fratnikov, @mark-grimes
https://github.com/mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of
your comment.


Reply to this email directly or view it on GitHub
#5184 (comment).

Thanks,
cheers, andreas

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @fratnikov, @mark-grimes can you please take care of it?

@mark-grimes
Copy link

merge

cmsbuild added a commit that referenced this pull request Sep 8, 2014
62x_SLHC version of renamed script with a uniqe name to avoid clashes ...
@cmsbuild cmsbuild merged commit 95a6159 into cms-sw:CMSSW_6_2_X_SLHC Sep 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants