B2G HLT DQM bug fix #5223
Merged
B2G HLT DQM bug fix #5223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he trigger was fired.
…ty. The module looks for a 'contains' rather than 'equals' so this is supported
|
A new Pull Request was created by @rappoccio for CMSSW_7_2_X. B2G HLT DQM bug fix It involves the following packages: HLTriggerOffline/B2G @nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda can you please review it and eventually sign? Thanks. |
|
+1 |
cmsbuild
added
comparison-pending
dqm-approved
fully-signed
tests-pending
and removed
comparison-pending
dqm-pending
pending-signatures
tests-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests. |
cmsbuild
added
comparison-pending
dqm-approved
fully-signed
tests-approved
and removed
comparison-pending
dqm-approved
fully-signed
tests-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). |
davidlange6
added a commit
that referenced
this pull request
Sep 9, 2014
…sep2014 B2G HLT DQM bug fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a bug fix for the B2G HLT DQM, where the selected histograms were accidentally not being filled.
I also added some future compatibility by removing the explicit "v1" at the end of the triggers. Since the code checks "contains" instead of "equals", this is supported.