Hgc jumpinghits fix v2

[pfs]

This supersedes PR#5132.
Besides fixing issues with boundary cells, a fix is provided for the SIM->RECO geometry in HEBack.

@vandreev11 @bsunanda @lgray Please keep an eye on this one

[cmsbuild]

A new Pull Request was created by @pfs (Pedro Silva) for CMSSW_6_2_X_SLHC.

Hgc jumpinghits fix v2

It involves the following packages:

Geometry/HGCalCommonData
SimG4CMS/Calo

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[pfs]

@bsunanda @vandreev11 @lgray
I pushed a new version of HGCalDDDConstants. With my setup i don't observe any jumping hits
for both v4 : http://psilva.web.cern.ch/psilva/HGCal/Geometry/v4/index.html
and v5 : http://psilva.web.cern.ch/psilva/HGCal/Geometry/v5/index.html
geometries. Can you try some real events?
thanks,
pedro

[lgray]

@pfs on it.

[cmsbuild]

Pull request #5235 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please check and sign again.

[vandreev11]

@pfs @lgray I checked with V4 geometry and do not see any problem from 100 dimuon events.
While I see still jumping hits in V5, 6 events out of 100 dimu events. At least in V4 it looks solved.

[lgray]

@pfs Bah, cvmfs or afs is really terrible today. I can't get the RECO step to get past parsing python (just keeps hanging...) ....

[lgray]

@pfs I confirm @vandreev11's findings. I no longer see jumping hits for muons in the HEB.

[lgray]

@pfs want to check photons and pions before we go ahead though.

[pfs]

@vandreev11 @bsunanda @lgray @mark-grimes
It looks as nothing wrong has been spotted yet. So we would like to proceed with the PR.

[lgray]

Agreed, just give a quick double check with the simple jet gun right now.

[vandreev11]

@pfs @lgray @mark-grimes @ianna yes, it is good with V4 geometry scenario, this is our test bed scenario, we proceed then with it

[lgray]

Yep, simple jet gun checks out, no more weird photon cluster splitting, etc. All looks well, please merge.

[pfs]

@lgray thanks!

[mark-grimes]

merge