Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid clang error in rootcling #5261

Merged
merged 1 commit into from
Sep 11, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Sep 10, 2014

A recent carry forward from the 7_2_X branch introduced a header for dictionary processing that clang cannot parse. This pull request hides the offending line of code from rootcling (genreflex),, thereby fixing the fatal build error in the ROOT6 IB.
Note: the same header fails to compile in the CLANG IB.
Please merge this trivial request as soon as convenient.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_2_ROOT6_X.

Avoid clang error in rootcling

It involves the following packages:

PhysicsTools/SelectorUtils

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@vadler
Copy link

vadler commented Sep 10, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_ROOT6_X IBs unless changes or unless it breaks tests.

@lgray
Copy link
Contributor

lgray commented Sep 10, 2014

@wmtan what does clang want instead (so that I can fix this when we switch or add a #elif)?

@Dr15Jones
Copy link
Contributor

I think typename should be removed.

@lgray
Copy link
Contributor

lgray commented Sep 10, 2014

Ok, gcc wanted the typename there iirc. Then again gcc doesn't seem to care so much about the correct use of that keyword. I'll fix this in another PR.

@wmtan
Copy link
Contributor Author

wmtan commented Sep 10, 2014

FWIW, the other C++ guru I consulted (Marc Paterno) also indicated that typename is wrong and should be removed. He was surprised that gcc accepted it.

@lgray
Copy link
Contributor

lgray commented Sep 10, 2014

As far as I can tell gcc seems to not care as long as you have enough 'typename's to satisfy a given situation... beyond that seems to treat it as no-op.

@wmtan
Copy link
Contributor Author

wmtan commented Sep 11, 2014

Can this be merged? It is somewhat urgent as it fixes a compilation error, and several knock-on link errors, in the IB.

nclopezo added a commit that referenced this pull request Sep 11, 2014
PhysicsTools/SelectorUtils -- Avoid clang error in rootcling
@nclopezo nclopezo merged commit 9feb8cb into cms-sw:CMSSW_7_2_ROOT6_X Sep 11, 2014
@wmtan wmtan deleted the FixBuildError branch September 17, 2014 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants