Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean RunningAverage use #5265

Merged
merged 2 commits into from
Sep 12, 2014
Merged

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented Sep 11, 2014

Purely stylistic changes mostly to set properly clean examples.

No regression expected. No regression observed.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_2_X.

Clean RunningAverage use

It involves the following packages:

RecoPixelVertexing/PixelTriplets
RecoTracker/TkHitPairs
RecoTracker/TkSeedGenerator

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @GiacomoSguazzoni, @rovere, @gpetruc, @cerati, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@StoyanStoynev
Copy link
Contributor

@cmsbuild please run the tests

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@StoyanStoynev
Copy link
Contributor

+1
The PR came after the 72X_pre6 deadline. I suppose it can pass as a bug-fix though it is really mostly stylistic as said (probably it is "safer" to run, I am not aware if it solves observed problems - likely not).

Tested 268e5e9 on top of CMSSW_7_2_X_2014-09-12-0200 .
No diffs observed in RECO LOCALLY (FWLite + DQM) and none expected. Note that there are some differences in jenkins, in particular in the "alternative" (DQM) comparisons - like wf 25 (known random number issue) and 4.53 (?), but not only. It looks to me the problems are only accumulating in jenkins... Any comment on the wf 4.53 issue?

@VinInn
Copy link
Contributor Author

VinInn commented Sep 12, 2014

It is mostly to produce good examples for my presentation at next reco meeting.
I would prefer to be in the release like this before other developers start to copy/paste

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

nclopezo added a commit that referenced this pull request Sep 12, 2014
@nclopezo nclopezo merged commit 349c90f into cms-sw:CMSSW_7_2_X Sep 12, 2014
@VinInn VinInn deleted the CleanRunningAverageUse branch April 21, 2017 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants