Fix setting the # of presamples for HcalUpgradeDataFrame. #5408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the constructors will use an uninitialized value of the presamples and modify it with a target presample size.
|
A new Pull Request was created by @matz-e (Matthias Wolf) for CMSSW_6_2_X_SLHC. Fix setting the # of presamples for HcalUpgradeDataFrame. It involves the following packages: DataFormats/HcalDigi @cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks. |
|
merge |
cmsbuild
added a commit
that referenced
this pull request
Sep 19, 2014
Fix setting the # of presamples for HcalUpgradeDataFrame.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor
HcalUpgradeDataFrame::HcalUpgradeDataFrame(HcalDetId id, int capId, int samples, int presamples)will use an uninitialized (random) value ofpresamples_to bit-or the passedpresamplesparameter. This will yield unexpected values forpresamples, which fail an assert in the HCAL trigger primitive chain starting here.Remove the bit-wise or to have well-behaved data frames.