-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hgc deadzone mitigation #5585
Hgc deadzone mitigation #5585
Conversation
A new Pull Request was created by @pfs (Pedro Silva) for CMSSW_6_2_X_SLHC. Hgc deadzone mitigation It involves the following packages: Geometry/FCalGeometry The following packages do not have a category, yet: Geometry/FCalGeometry @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks. |
Why first four parameters, which are essentially not modified integers, are passed by reference here? |
@fratnikov I don't know exactly - i guess historical (@bsunanda?), but I agree it doesn't make sense. I removed it. |
Pull request #5585 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please check and sign again. |
Below is the summary of the geometry closure test.
|
@fratnikov interesting i was expecting a decrease of the dead zones but indeed not 0% dead zones |
Are you going to resolve the dead zone issue before we go ahead with this
|
I'll have stable internet connection only Monday. The test I need to do can be run early morning. |
What we have right now is essentially the same as we had before. I'd expect
|
Deadzone size is not the priority of the current release scheduled for Monday. On Sep 27, 2014, at 11:35 PM, Fedor Ratnikov wrote:
|
Is 3-cells offset in v5 geometry tests an issue for the release? On Sep 28, 2014 1:52 AM, "vandreev11" notifications@github.com wrote:
|
All right, we go for the SLHC18 release with all the fixes up to date. We need a trial On Sep 28, 2014, at 4:52 PM, Fedor Ratnikov wrote:
|
merge |
This includes some further protections for invalid cells set by HGCalDDDConstants, following the tests from Fedor.
It also extends the evaluation of the boundaries of the cells to mitigate further the dead zone in the active material.
@vandreev11 @bsunanda @lgray please follow this one as well