-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pythia 8.200pre2 (71x) #5603
Pythia 8.200pre2 (71x) #5603
Conversation
Pythia8.200pre2 interface changes Conflicts: FastSimulation/ParticleDecay/src/PythiaDecays.cc
… fragments for common pythia8 settings
+1 |
A new Pull Request was created by @bendavid (Josh Bendavid) for CMSSW_7_1_X. Pythia 8.200pre2 (71x) It involves the following packages: Configuration/Generator @cmsbuild, @civanch, @nclopezo, @mdhildreth, @lveldere can you please review it and eventually sign? Thanks. |
@@ -8,7 +8,7 @@ | |||
#include <HepMC/GenEvent.h> | |||
#include <HepMC/GenParticle.h> | |||
#include <Pythia8/Pythia.h> | |||
#include <Pythia8/Pythia8ToHepMC.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Lukas,
In 71x it seemed as though the code setting the flags was not present at all. Was fastsim + pythia 8 really working already in 71x or only in 72x?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, you're right.
In 71X there was a trial version, implemented probably last year, and not
used.
No reason to bother about it.
Thanks
Lukas
On Mon, Sep 29, 2014 at 12:55 PM, Josh Bendavid notifications@github.com
wrote:
In FastSimulation/ParticleDecay/interface/PythiaDecays.h:
@@ -8,7 +8,7 @@
#include <HepMC/GenEvent.h>
#include <HepMC/GenParticle.h>
#include <Pythia8/Pythia.h>
-#include <Pythia8/Pythia8ToHepMC.h>Hi Lukas,
In 71x it seemed as though the code setting the flags was not present at
all. Was fastsim + pythia 8 really working already in 71x or only in 72x?—
Reply to this email directly or view it on GitHub
https://github.com/cms-sw/cmssw/pull/5603/files#r18147404.
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @Degano can you please take care of it? |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @Degano can you please take care of it? |
Backport of interface changes for pythia 8.2.
Needs to be merged together with
cms-sw/cmsdist#1065