Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pythia 8.200pre2 (71x) #5603

Merged
5 commits merged into from
Oct 9, 2014
Merged

Pythia 8.200pre2 (71x) #5603

5 commits merged into from
Oct 9, 2014

Conversation

bendavid
Copy link
Contributor

Backport of interface changes for pythia 8.2.
Needs to be merged together with
cms-sw/cmsdist#1065

@bendavid
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bendavid (Josh Bendavid) for CMSSW_7_1_X.

Pythia 8.200pre2 (71x)

It involves the following packages:

Configuration/Generator
FastSimulation/ParticleDecay
GeneratorInterface/PartonShowerVeto
GeneratorInterface/Pythia8Interface

@cmsbuild, @civanch, @nclopezo, @mdhildreth, @lveldere can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@@ -8,7 +8,7 @@
#include <HepMC/GenEvent.h>
#include <HepMC/GenParticle.h>
#include <Pythia8/Pythia.h>
#include <Pythia8/Pythia8ToHepMC.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bendavid

Hi Josh

In #5602 you changed the way the pythia flags are set in this file.
Why not here in 71?

Cheers

Lukas

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Lukas,
In 71x it seemed as though the code setting the flags was not present at all. Was fastsim + pythia 8 really working already in 71x or only in 72x?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, you're right.

In 71X there was a trial version, implemented probably last year, and not
used.

No reason to bother about it.

Thanks

Lukas

On Mon, Sep 29, 2014 at 12:55 PM, Josh Bendavid notifications@github.com
wrote:

In FastSimulation/ParticleDecay/interface/PythiaDecays.h:

@@ -8,7 +8,7 @@
#include <HepMC/GenEvent.h>
#include <HepMC/GenParticle.h>
#include <Pythia8/Pythia.h>
-#include <Pythia8/Pythia8ToHepMC.h>

Hi Lukas,
In 71x it seemed as though the code setting the flags was not present at
all. Was fastsim + pythia 8 really working already in 71x or only in 72x?


Reply to this email directly or view it on GitHub
https://github.com/cms-sw/cmssw/pull/5603/files#r18147404.

@ghost
Copy link

ghost commented Sep 29, 2014

+1
Tested against cms-sw/cmsdist#1065.
Usual matrix tests ran fine: 401.0,1306.0,101.0,1003.0,50101.0,9.0.

@ghost ghost mentioned this pull request Sep 29, 2014
@lveldere
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @Degano can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @Degano can you please take care of it?

ghost pushed a commit that referenced this pull request Oct 9, 2014
@ghost ghost merged commit 49c7d2a into cms-sw:CMSSW_7_1_X Oct 9, 2014
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants