Changed global array of const char* so addresses can not be changed #5659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed arrays from 'const char* []' to 'const char* const []'. This way the pointers in the array can not be changed to point to a new non-mutable character array. This fixes a thread safety complaint from the static analyzer.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_3_X. Changed global array of const char* so addresses can not be changed It involves the following packages: SimTracker/TrackHistory @cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks. |
|
+1 |
davidlange6
added a commit
that referenced
this pull request
Oct 5, 2014
…kHistory Changed global array of const char* so addresses can not be changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed arrays from 'const char* []' to 'const char* const []'. This
way the pointers in the array can not be changed to point to a new
non-mutable character array.
This fixes a thread safety complaint from the static analyzer.