Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen relval cmssw 7 2 0 pre7 #5727

Merged

Conversation

franzoni
Copy link

@franzoni franzoni commented Oct 7, 2014

@bendavid
@inugent

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2014

A new Pull Request was created by @franzoni (Giovanni Franzoni) for CMSSW_7_2_X.

Gen relval cmssw 7 2 0 pre7

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @davidlange6, @franzoni, @nclopezo, @vlimant can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@franzoni
Copy link
Author

franzoni commented Oct 7, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests. @nclopezo can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it?

davidlange6 added a commit that referenced this pull request Oct 9, 2014
@davidlange6 davidlange6 merged commit aa6eaf6 into cms-sw:CMSSW_7_2_X Oct 9, 2014
@davidlange6
Copy link
Contributor

@franzoni @fabozzi - seems that we need a 73x version of this PR (or perhaps using the 730pre1 relvals). Could you make one? Thanks.

@franzoni
Copy link
Author

Hello @davidlange6 ,

can you please illustrate a bit what you have in mind, what problem triggers your request ?

The GEN 730pre1 relvals came out ok (that I am aware of : https://hypernews.cern.ch/HyperNews/CMS/get/relval/3201.html)
and the datatier, eventcontent and HARVESTGEN all appear in order, to me.

https://github.com/cms-sw/cmssw/blob/CMSSW_7_3_X/Configuration/PyReleaseValidation/python/relval_steps.py#L1064
https://github.com/cms-sw/cmssw/blob/CMSSW_7_3_X/Configuration/PyReleaseValidation/python/relval_steps.py#L1064

Cheers,
g.

@davidlange6
Copy link
Contributor

errrr , indeed,- it seems I responded to the wrong thread.

was meant to ask to update the GEN-SIM inputs in 73x to be that of at least 720pre7 as is already done in 72x. I can find the right PR if its not clear.

On Oct 27, 2014, at 3:14 PM, Giovanni Franzoni notifications@github.com
wrote:

Hello @davidlange6 ,

can you please illustrate a bit what you have in mind, what problem triggers your request ?

The GEN 730pre1 relvals came out ok (that I am aware of : https://hypernews.cern.ch/HyperNews/CMS/get/relval/3201.html)
and the datatier, eventcontent and HARVESTGEN all appear in order, to me.

https://github.com/cms-sw/cmssw/blob/CMSSW_7_3_X/Configuration/PyReleaseValidation/python/relval_steps.py#L1064
https://github.com/cms-sw/cmssw/blob/CMSSW_7_3_X/Configuration/PyReleaseValidation/python/relval_steps.py#L1064

Cheers,
g.


Reply to this email directly or view it on GitHub.

@franzoni
Copy link
Author

HI @davidlange6, ok, understand what you mean.
Since GEN-SIM have been remade in 73pre1, with @fabozzi and @nancymarinelli we had a different plan: updating the matrix to point directly to those gen-sim (which is a natural by-product of the pileup relvals injection).
Cheers, g.

@davidlange6
Copy link
Contributor

would be great… just want something pre7 or newer so we can reduce the errors we see.

On Oct 27, 2014, at 4:10 PM, Giovanni Franzoni notifications@github.com
wrote:

HI @davidlange6, ok, understand what you mean.
Since GEN-SIM have been remade in 73pre1, with @fabozzi and @nancymarinelli we had a different plan: updating the matrix to point directly to those gen-sim (which is a natural by-product of the pileup relvals injection).
Cheers, g.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants