Minor fixes that do not affect offline DQM #5776

yiiyama · 2014-10-10T13:13:25Z

A bug was found in the online mode of ECAL DQM. The fix is relevant only for 7_1_X since that's the online release, but nevertheless making a PR to 7_3_X just to be in synch.

cmsbuild · 2014-10-10T13:17:31Z

A new Pull Request was created by @yiiyama (Yutaro Iiyama) for CMSSW_7_3_X.

Minor fixes that do not affect offline DQM

It involves the following packages:

DQM/EcalCommon
DQM/EcalMonitorClient
DQM/EcalMonitorTasks

The following packages do not have a category, yet:

DQM/EcalMonitorClient
DQM/EcalMonitorTasks

@nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

Dr15Jones · 2014-10-10T13:24:29Z

Since you are touching the same file, could you please remove the use of TStopwatch? It is very thread inefficient (it takes locks internally). If you really must do timing measurements internally (which seems strange to me) than please look at the new 'chrono' facility in C++11.

yiiyama · 2014-10-10T13:41:05Z

Sure, I wasn't aware of that. Sorry. Indeed the time evaluation was a relic of the past, so I removed the related parts of the code.

cmsbuild · 2014-10-10T13:42:10Z

Pull request #5776 was updated. @nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda can you please check and sign again.

Dr15Jones · 2014-10-10T13:50:03Z

Thanks.

cmsbuild · 2014-10-10T14:23:12Z

Pull request #5776 was updated. @nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda can you please check and sign again.

cmsbuild · 2014-10-10T14:46:16Z

-1
Tested at: 9e77fbc
When I ran the RelVals I found an error in the following worklfows:
4.22 step5

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step5_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log
----- Begin Fatal Exception 10-Oct-2014 16:21:19 CEST-----------------------
An exception of category 'InvalidOperation' occurred while
   [0] Processing run: 160960 luminosityBlock: 277
   [1] Calling endLuminosityBlock for unscheduled module EcalDQMonitorClient/'ecalMonitorClient'
Exception Message:
MESet::ConstBin::Ctor: ME 0 does not exist for MESet %(subdet)s/%(prefix)sOccupancyTask/%(prefix)sOT digi occupancy %(sm)s
----- End Fatal Exception -------------------------------------------------

8.0 step5

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step5_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log
----- Begin Fatal Exception 10-Oct-2014 16:21:57 CEST-----------------------
An exception of category 'InvalidOperation' occurred while
   [0] Processing run: 1 luminosityBlock: 1
   [1] Calling endLuminosityBlock for unscheduled module EcalDQMonitorClient/'ecalMonitorClient'
Exception Message:
MESet::ConstBin::Ctor: ME 0 does not exist for MESet %(subdet)s/%(prefix)sOccupancyTask/%(prefix)sOT digi occupancy %(sm)s
----- End Fatal Exception -------------------------------------------------

1306.0 step4

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step4_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 10-Oct-2014 16:23:40 CEST-----------------------
An exception of category 'InvalidOperation' occurred while
   [0] Processing run: 1 luminosityBlock: 1
   [1] Calling endLuminosityBlock for unscheduled module EcalDQMonitorClient/'ecalMonitorClient'
Exception Message:
MESet::ConstBin::Ctor: ME 0 does not exist for MESet %(subdet)s/%(prefix)sOccupancyTask/%(prefix)sOT digi occupancy %(sm)s
----- End Fatal Exception -------------------------------------------------

1000.0 step4

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step4_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log
----- Begin Fatal Exception 10-Oct-2014 16:25:18 CEST-----------------------
An exception of category 'InvalidOperation' occurred while
   [0] Processing run: 165121 luminosityBlock: 62
   [1] Calling endLuminosityBlock for unscheduled module EcalDQMonitorClient/'ecalMonitorClient'
Exception Message:
MESet::ConstBin::Ctor: ME 0 does not exist for MESet %(subdet)s/%(prefix)sOccupancyTask/%(prefix)sOT digi occupancy %(sm)s
----- End Fatal Exception -------------------------------------------------

1003.0 step3

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step3_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log
----- Begin Fatal Exception 10-Oct-2014 16:25:52 CEST-----------------------
An exception of category 'InvalidOperation' occurred while
   [0] Processing run: 191226 luminosityBlock: 398
   [1] Calling endLuminosityBlock for unscheduled module EcalDQMonitorClient/'ecalMonitorClient'
Exception Message:
MESet::ConstBin::Ctor: ME 0 does not exist for MESet %(subdet)s/%(prefix)sOccupancyTask/%(prefix)sOT digi occupancy %(sm)s
----- End Fatal Exception -------------------------------------------------

9.0 step4

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step4_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
----- Begin Fatal Exception 10-Oct-2014 16:30:00 CEST-----------------------
An exception of category 'InvalidOperation' occurred while
   [0] Processing run: 1 luminosityBlock: 1
   [1] Calling endLuminosityBlock for unscheduled module EcalDQMonitorClient/'ecalMonitorClient'
Exception Message:
MESet::ConstBin::Ctor: ME 0 does not exist for MESet %(subdet)s/%(prefix)sOccupancyTask/%(prefix)sOT digi occupancy %(sm)s
----- End Fatal Exception -------------------------------------------------

25.0 step4

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step4_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log
----- Begin Fatal Exception 10-Oct-2014 16:30:22 CEST-----------------------
An exception of category 'InvalidOperation' occurred while
   [0] Processing run: 1 luminosityBlock: 1
   [1] Calling endLuminosityBlock for unscheduled module EcalDQMonitorClient/'ecalMonitorClient'
Exception Message:
MESet::ConstBin::Ctor: ME 0 does not exist for MESet %(subdet)s/%(prefix)sOccupancyTask/%(prefix)sOT digi occupancy %(sm)s
----- End Fatal Exception -------------------------------------------------

4.53 step4

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step4_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log
----- Begin Fatal Exception 10-Oct-2014 16:32:38 CEST-----------------------
An exception of category 'InvalidOperation' occurred while
   [0] Processing run: 194533 luminosityBlock: 329
   [1] Calling endLuminosityBlock for unscheduled module EcalDQMonitorClient/'ecalMonitorClient'
Exception Message:
MESet::ConstBin::Ctor: ME 0 does not exist for MESet %(subdet)s/%(prefix)sOccupancyTask/%(prefix)sOT digi occupancy %(sm)s
----- End Fatal Exception -------------------------------------------------

25202.0 step4

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVEST+MINIAODMC/step4_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVEST+MINIAODMC.log
----- Begin Fatal Exception 10-Oct-2014 16:44:50 CEST-----------------------
An exception of category 'InvalidOperation' occurred while
   [0] Processing run: 1 luminosityBlock: 1
   [1] Calling endLuminosityBlock for unscheduled module EcalDQMonitorClient/'ecalMonitorClient'
Exception Message:
MESet::ConstBin::Ctor: ME 0 does not exist for MESet %(subdet)s/%(prefix)sOccupancyTask/%(prefix)sOT digi occupancy %(sm)s
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5776/17/summary.html

yiiyama · 2014-10-10T14:54:37Z

Well it apparently does affect the offline - will fix this asap.

cmsbuild · 2014-10-10T15:14:49Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5776/17/summary.html

deguio · 2014-10-22T12:36:51Z

+1

deguio · 2014-10-24T08:32:43Z

not sure why the 'new-package-pending' label is triggered..

cmsbuild · 2014-10-24T08:39:05Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

Minor fixes that do not affect offline DQM

Minor fixes that do not affect offline DQM

9e77fbc

cmsbuild added this to the Next CMSSW_7_3_X milestone Oct 10, 2014

cmsbuild added comparison-pending dqm-pending new-package-pending pending-signatures tests-pending labels Oct 10, 2014

Removing task time evaluation

c2b4299

one more line

0a39dc7

cmsbuild added comparison-pending dqm-pending new-package-pending pending-signatures tests-rejected and removed comparison-pending dqm-pending new-package-pending pending-signatures tests-pending labels Oct 10, 2014

cmsbuild removed comparison-pending dqm-pending labels Oct 10, 2014

cmsbuild added comparison-available dqm-pending new-package-pending pending-signatures tests-approved labels Oct 22, 2014

cmsbuild added comparison-available dqm-approved new-package-pending pending-signatures tests-approved and removed comparison-available dqm-pending new-package-pending pending-signatures tests-approved labels Oct 22, 2014

cmsbuild removed comparison-available dqm-approved new-package-pending pending-signatures tests-approved labels Oct 24, 2014

cmsbuild added comparison-available dqm-approved fully-signed tests-approved labels Oct 24, 2014

ktf added a commit that referenced this pull request Oct 24, 2014

Merge pull request #5776 from yiiyama/ecaldqm-minor-fixes

a4996f6

Minor fixes that do not affect offline DQM

ktf merged commit a4996f6 into cms-sw:CMSSW_7_3_X Oct 24, 2014

yiiyama deleted the ecaldqm-minor-fixes branch October 7, 2015 12:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Minor fixes that do not affect offline DQM #5776

Minor fixes that do not affect offline DQM #5776

yiiyama commented Oct 10, 2014

cmsbuild commented Oct 10, 2014

Dr15Jones commented Oct 10, 2014

yiiyama commented Oct 10, 2014

cmsbuild commented Oct 10, 2014

Dr15Jones commented Oct 10, 2014

cmsbuild commented Oct 10, 2014

cmsbuild commented Oct 10, 2014

yiiyama commented Oct 10, 2014

cmsbuild commented Oct 10, 2014

deguio commented Oct 22, 2014

deguio commented Oct 24, 2014

cmsbuild commented Oct 24, 2014

Minor fixes that do not affect offline DQM #5776

Minor fixes that do not affect offline DQM #5776

Conversation

yiiyama commented Oct 10, 2014

cmsbuild commented Oct 10, 2014

Dr15Jones commented Oct 10, 2014

yiiyama commented Oct 10, 2014

cmsbuild commented Oct 10, 2014

Dr15Jones commented Oct 10, 2014

cmsbuild commented Oct 10, 2014

cmsbuild commented Oct 10, 2014

yiiyama commented Oct 10, 2014

cmsbuild commented Oct 10, 2014

deguio commented Oct 22, 2014

deguio commented Oct 24, 2014

cmsbuild commented Oct 24, 2014