Add module geometry to tt #5789
Conversation
|
A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_7_3_X. Add module geometry to tt It involves the following packages: DataFormats/TrackerCommon @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
| } | ||
| } | ||
| return SiStripDetId::UNKNOWNGEOMETRY; | ||
| } |
There was a problem hiding this comment.
this looks strikingly similar to SiStripDetId::ModuleGeometry SiStripDetId::moduleGeometry() const do we need a copy-paste?
There was a problem hiding this comment.
the other one will go away one a migration is completed
On Oct 12, 2014, at 4:04 PM, Slava Krutelyov notifications@github.com
wrote:
this looks strikingly similar to SiStripDetId::ModuleGeometry SiStripDetId::moduleGeometry() const do we need a copy-paste?
—
Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
oh, ok.
I took this out of the context
|
@cmsbuild please test |
|
+1 |
DataFormats/TrackerCommon -- Add module geometry to tt
I had forgotten the moduleGeometry(DetId) method a year or so ago in TrackerTopology. Adding it (Thanks to Vincenzo for noticing)