-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module geometry to tt #5789
Add module geometry to tt #5789
Conversation
A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_7_3_X. Add module geometry to tt It involves the following packages: DataFormats/TrackerCommon @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
} | ||
} | ||
return SiStripDetId::UNKNOWNGEOMETRY; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks strikingly similar to SiStripDetId::ModuleGeometry SiStripDetId::moduleGeometry() const
do we need a copy-paste?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the other one will go away one a migration is completed
On Oct 12, 2014, at 4:04 PM, Slava Krutelyov notifications@github.com
wrote:
this looks strikingly similar to SiStripDetId::ModuleGeometry SiStripDetId::moduleGeometry() const do we need a copy-paste?
—
Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, ok.
I took this out of the context
@cmsbuild please test |
+1 |
DataFormats/TrackerCommon -- Add module geometry to tt
I had forgotten the moduleGeometry(DetId) method a year or so ago in TrackerTopology. Adding it (Thanks to Vincenzo for noticing)