Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecoMET/METPUSubtraction -- Removed 3 unused functions #5849

Merged
merged 1 commit into from
Oct 16, 2014

Conversation

nclopezo
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nclopezo (David Mendez) for CMSSW_7_3_X.

RecoMET/METPUSubtraction -- Removed 3 unused functions

It involves the following packages:

RecoMET/METPUSubtraction

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@nhanvtran, @mariadalfonso, @TaiSakuma, @mmarionncern, @schoef this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@StoyanStoynev
Copy link
Contributor

@mmarionncern please note the changes and leave a comment

@mmarionncern
Copy link

+1

Works for me. (Currently rewriting the code anyway, but in the meantime it does not hurt to remove the warnings)

ktf added a commit that referenced this pull request Oct 16, 2014
RecoMET/METPUSubtraction -- Removed 3 unused functions
@ktf ktf merged commit 0cd3486 into cms-sw:CMSSW_7_3_X Oct 16, 2014
@ktf
Copy link
Contributor

ktf commented Oct 16, 2014

Bypassing reco signature, just in case @StoyanStoynev is having dinner.

@StoyanStoynev
Copy link
Contributor

It's fine, should not have any effect.
Anyway, https://cmssdt.cern.ch/ is off and I can not see the jenkins (I believe they were fine).

@StoyanStoynev
Copy link
Contributor

Ah yeah, there was a power cut I've heard...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants