Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Castor l1 tech trigger sim #5862

Merged
merged 4 commits into from Nov 10, 2014

Conversation

cwohrman
Copy link
Contributor

Apply Simulation of the four L1 technical trigger from CASTOR ( gap trigger, jet trigger, EM trigger and muon trigger ).

The simulation is implemented in the EDProducer SimCalorimetry/CastorSim/plugins/CastorTTRecord.cc/h and produces an L1GtTechnicalTriggerRecord object.
The producer is setuped via SimCalorimetry/CastorSim/python/castorTTRecord_cfi.py.
Need to change L1Trigger/Configuration/python/SimL1Emulator_cff.py to run the producer and collect trigger decisions from CastorTTRecord.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@mulhearn
Copy link
Contributor

+1

@cwohrman
Copy link
Contributor Author

Dear all,

I wanted to ask if there is something more I can do. Since the last action is 13 days ago and I'm not sure if there still something missing from my side to get the signatures and the merging.

Thanks and best regards
Hauke

@civanch
Copy link
Contributor

civanch commented Nov 10, 2014

+1
it seems that all signatures are in place long ago but because it is a new package it is stacked.
@ktf , can you , please, comment.

@ktf
Copy link
Contributor

ktf commented Nov 10, 2014

I just noticed it creates a new SimCalorimetry/CastorTechTrigProducer package. Why can't we simply reuse SimCalorimetry/CastorSim???

@civanch
Copy link
Contributor

civanch commented Nov 10, 2014

Because of extra dependency of SIM on HLT. Both ECAL and HCAL have separate sub-packes, we did the same for Castor.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Nov 10, 2014
@cmsbuild cmsbuild merged commit 2cf1b18 into cms-sw:CMSSW_7_3_X Nov 10, 2014
@cwohrman
Copy link
Contributor Author

Dear all,
thank you very much!

Hauke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants