Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify PixelEndcaoName to handle pilot-blades #5867

Merged
merged 1 commit into from
Oct 20, 2014

Conversation

dkotlins
Copy link
Contributor

Modify PixelEndcapName class to handle the new pixel fpix pilot-blades.
Does not change anything for the present (phase0) detector.

@dkotlins
Copy link
Contributor Author

Should go on the top of the #5816 request.
Which I assume is automatic since 5816 has been merged already.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dkotlins for CMSSW_7_3_X.

modify PixelEndcaoName to handle pilot-blades

It involves the following packages:

DataFormats/SiPixelDetId

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @VinInn, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Oct 18, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Oct 20, 2014
DataFormats/SiPixelDetId -- modify PixelEndcaoName to handle pilot-blades
@nclopezo nclopezo merged commit 5930324 into cms-sw:CMSSW_7_3_X Oct 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants