[RFC] Add RefToBase member `holder_' in Reflex dicts.

[davidlt]

RefToBase is a templated class with a private memeber holder_ of reftobase::BaseHolder<value_type>* type. The following type is not part of any dictionary, thus holder_ is not serialized.

There are two options:

1. Make holder_ transient, which would match the current behavior (not saving it), I assume.
2. Adding a dictionary for reftobase::BaseHolder<value_type>* to make holder_ serializable by ROOT.

Example error generated by ROOT:

Error in <TStreamerInfo::Build:>: edm::RefToBase<reco::Electron>:
edm::reftobase::BaseHolder<reco::Electron>* has no streamer or
dictionary, data member holder_ will not be saved

The following should resolve errors for 9 dictionaries:

• edm::RefToBase<reco::WMuNuCandidatePtr>
• edm::RefToBase<reco::WMuNuCandidate>
• edm::RefToBase<reco::PhotonCore>
• edm::RefToBase<reco::Photon>
• edm::RefToBase<reco::Muon>
• edm::RefToBase<reco::GsfElectronCore>
• edm::RefToBase<reco::GsfElectron>
• edm::RefToBase<reco::Electron>
• edm::RefToBase<PSimHit>

You can test using edmClassStorageSize, e.g.:

edmClassStorageSize 'edm::RefToBase<reco::GsfElectronCore>'

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

[ktf]

@Dr15Jones, @wmtan can you look into this and confirm it's ok?

[Dr15Jones]

holder_ must be stored since it holds all the information we need to retrieve the data. BaseHolder is an abstract base class but its concrete implementations ultimately hold an edm::Ref which must be stored. So it looks like we need to generate the missing dictionaries.

[davidlt]

@Dr15Jones, thanks. I will update the branch.

[ktf]

@davidlt any news about this one?

[cmsbuild]

The following categories have been rejected by eulisse (a.k.a. @ktf on GitHub): Analysis

@cms-git-visualization, @cms-git-analysis, @cms-git-core

[cmsbuild]

The following categories have been signed by mikeh (a.k.a. @mdhildreth on GitHub): Full Simulation

@cms-git-simulation, @cms-git-fastsim, @cms-git-operations, @cms-git-geometry

[cmsbuild]

The following categories have been signed by mikeh (a.k.a. @mdhildreth on GitHub): Full Simulation

@cms-git-simulation, @cms-git-fastsim, @cms-git-operations, @cms-git-geometry

[cmsbuild]

The following categories have been rejected by mikeh (a.k.a. @mdhildreth on GitHub): Full Simulation

@cms-git-simulation, @cms-git-fastsim, @cms-git-operations, @cms-git-geometry

[davidlt]

@Dr15Jones , the type (edm::reftobase::BaseHolder<value_type>) itself doesn't seem to have any data members, but I updated pull request to add the missing types to dictionary.

[ktf]

@Dr15Jones can you look into this?

[cmsbuild]

The following categories have been rejected by @slava77: Reconstruction

@cms-git-reconstruction

[slava77]

oops, how do I undo the rejection?
there is no confirm button and the text jumps up and down when I click a
button nearby.

On 7/23/13 11:14 AM, cmsbuild wrote:

The following categories have been rejected by @slava77
https://github.com/slava77: Reconstruction

@cms-git-reconstruction

—
Reply to this email directly or view it on GitHub
#59 (comment).

---

Vyacheslav (Slava) Krutelyov
TAMU: Physics Dept Texas A&M MS4242, College Station, TX 77843-4242
CERN: 42-R-027
AIM/Skype: siava16 googleTalk: slava77@gmail.com
(630) 291-5128 Cell (US) +41 76 275 7116 Cell (CERN)

---

[ktf]

Click on sign and it will move it from the rejected state to the approved state.

[slava77]

On 7/23/13 11:29 AM, Giulio Eulisse wrote:

Click on sign and it will move it from the rejected state to the
approved state.

will it change the state to "signed"? I don't want to sign it until I
test it.
There are other rejection signatures in this request already,
I don't see a point of testing it until those are cleared.

—
Reply to this email directly or view it on GitHub
#59 (comment).

---

Vyacheslav (Slava) Krutelyov
TAMU: Physics Dept Texas A&M MS4242, College Station, TX 77843-4242
CERN: 42-R-027
AIM/Skype: siava16 googleTalk: slava77@gmail.com
(630) 291-5128 Cell (US) +41 76 275 7116 Cell (CERN)

---

[Dr15Jones]

This change looks fine to me. I double checked that classes which inherited from HolderBase have dictionaries declared and they do

[slava77]

@Dr15Jones it's nice to hear this is ok for the CORE.
@ktf Why was it rejected for Analysis?
@mdhildreth Why was it rejected for FullSim?

[ktf]

I think I rejected by mistake while trying out something for Volker. @vadler, can you check and approve?

[ktf]

@vadler can you please look and approve?

[ktf]

@vadler ???

[vadler]

I'm catching up with GIT stuff after vacation. This one will be done tomorrow morning.
BTW: I can see some more rejects in the TC.

[cmsbuild]

The following categories have been signed by @vadler: Analysis

@cms-git-analysis

[cmsbuild]

The following categories have been signed by @vadler: Analysis

@cms-git-analysis

[cmsbuild]

The following categories have been signed by mikeh (a.k.a. @mdhildreth on GitHub): Full Simulation

@cms-git-simulation, @cms-git-fastsim, @cms-git-operations, @cms-git-geometry

[ktf]

@nclopezo can you test it, please?

[nclopezo]

Hi,

I tested these changes in CMSSW_7_0_X_2013-08-09-0200. All tests passed.

You can see the logs in:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/lastBuild/consoleFull

[ktf]

As discussed in ORP, and given we are at the beginning pre3, I simply approve it.