-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event number from 32 to 64 bits in Core #5973
Conversation
Change the event number in the EventID from 32 bits to 64 bits. This includes only changes for the Core part of CMSSW. There are a couple hundred places outside the Core code where this value is being assigned to types with less than 64 bits that will also need changes to work properly with data that has an event number exceeding 32 bits. Includes tests for the changes in the Core code.
A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_3_X. Event number from 32 to 64 bits in Core It involves the following packages: DPGAnalysis/SiStripTools @nclopezo, @monttj, @cmsbuild, @Dr15Jones, @StoyanStoynev, @slava77, @vadler, @ktf can you please review it and eventually sign? Thanks. |
+1 |
My tests were on top of CMSSW_7_3_X_2014-10-25-0200 (gcc491). |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
Event number from 32 to 64 bits in Core
Change the event number in the EventID from 32 bits to
64 bits. This includes only changes for the Core part
of CMSSW. There are a couple hundred places outside the
Core code where this value is being assigned to types
with less than 64 bits that will also need changes to
work properly with data that has an event number exceeding
32 bits. Includes tests for the changes in the Core code.