Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event number from 32 to 64 bits in Core #5973

Merged
merged 1 commit into from Oct 28, 2014

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Oct 23, 2014

Change the event number in the EventID from 32 bits to
64 bits. This includes only changes for the Core part
of CMSSW. There are a couple hundred places outside the
Core code where this value is being assigned to types
with less than 64 bits that will also need changes to
work properly with data that has an event number exceeding
32 bits. Includes tests for the changes in the Core code.

Change the event number in the EventID from 32 bits to
64 bits. This includes only changes for the Core part
of CMSSW. There are a couple hundred places outside the
Core code where this value is being assigned to types
with less than 64 bits that will also need changes to
work properly with data that has an event number exceeding
32 bits. Includes tests for the changes in the Core code.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_3_X.

Event number from 32 to 64 bits in Core

It involves the following packages:

DPGAnalysis/SiStripTools
DataFormats/FWLite
DataFormats/Provenance
DataFormats/TestObjects
EgammaAnalysis/ElectronTools
FWCore/Framework
FWCore/Integration
FWCore/MessageLogger
FWCore/Modules
FWCore/ParameterSet
FWCore/PythonParameterSet
FWCore/Sources
IOPool/Input
IOPool/SecondaryInput
IOPool/Streamer
PhysicsTools/FWLite
RecoLocalMuon/RPCRecHit
RecoMuon/L2MuonIsolationProducer
RecoMuon/L3MuonIsolationProducer

@nclopezo, @monttj, @cmsbuild, @Dr15Jones, @StoyanStoynev, @slava77, @vadler, @ktf can you please review it and eventually sign? Thanks.
@wmtan, @threus, @abbiendi, @bellan, @battibass, @venturia, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@Dr15Jones
Copy link
Contributor

+1

@StoyanStoynev
Copy link
Contributor

My tests were on top of CMSSW_7_3_X_2014-10-25-0200 (gcc491).

@vadler
Copy link

vadler commented Oct 28, 2014

+1
Trivial for AT.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Oct 28, 2014
Event number from 32 to 64 bits in Core
@cmsbuild cmsbuild merged commit 4871267 into cms-sw:CMSSW_7_3_X Oct 28, 2014
@wddgit wddgit deleted the eventNumber64Bits branch May 19, 2015 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants