Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TrunCastChecker to look at ImplicitCastExpr when the child is a #5976

Merged
merged 3 commits into from Oct 28, 2014
Merged

Update TrunCastChecker to look at ImplicitCastExpr when the child is a #5976

merged 3 commits into from Oct 28, 2014

Conversation

gartung
Copy link
Member

@gartung gartung commented Oct 23, 2014

BinaryOperator with at least one side of type EventNumber_t/

…a BinaryOperator with at least one side of type EventNumber_t/
@gartung
Copy link
Member Author

gartung commented Oct 24, 2014

@ktf

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_3_X.

Update TrunCastChecker to look at ImplicitCastExpr when the child is a

It involves the following packages:

Utilities/StaticAnalyzers

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #5976 was updated. @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please check and sign again.

@gartung gartung closed this Oct 27, 2014
@cmsbuild
Copy link
Contributor

@gartung
Copy link
Member Author

gartung commented Oct 28, 2014

@Dr15Jones @ktf

@ktf
Copy link
Contributor

ktf commented Oct 28, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Oct 28, 2014
Update TrunCastChecker to look at ImplicitCastExpr when the child is a
@cmsbuild cmsbuild merged commit 211ea47 into cms-sw:CMSSW_7_3_X Oct 28, 2014
@gartung gartung deleted the clang-trunc-int-checker-update branch October 28, 2014 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants