Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment Packages -- changes for large object passed by value #599

Merged
merged 1 commit into from Aug 27, 2013
Merged

Alignment Packages -- changes for large object passed by value #599

merged 1 commit into from Aug 27, 2013

Conversation

gartung
Copy link
Member

@gartung gartung commented Aug 23, 2013

found by clang static analyzer cms.ArgSizeChecker

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_0_X.

Alignment Packages -- changes for large object passed by value

It involves the following packages:

Alignment/CommonAlignment
Alignment/CommonAlignmentParametrization
Alignment/TrackerAlignment
Alignment/CommonAlignmentAlgorithm
Alignment/CocoaModel
Alignment/CocoaApplication
Alignment/CommonAlignmentProducer
Alignment/CocoaFit
Alignment/MuonAlignmentAlgorithms
Alignment/CocoaAnalysis
Alignment/KalmanAlignmentAlgorithm
Alignment/MuonAlignment
Alignment/CocoaDaq
Alignment/TwoBodyDecay
Alignment/HIPAlignmentAlgorithm
Alignment/OfflineValidation

@demattia, @rcastello can you please review it and eventually sign? Thanks.

@cmsbuild
Copy link
Contributor

Pull request #599 was updated. Signatures reset, please check and sign again.

@demattia
Copy link
Contributor

Would it be possible to have a round of tests?
Maybe it could be merged with pull reguest #600 and tested together.

@apfeiffer1
Copy link
Contributor

Would it be possible to have a round of tests?
Maybe it could be merged with pull reguest #600 and tested together

+1 for this request as well -- and please add in #601 as well. :)

@nclopezo
Copy link
Contributor

Hi All,

I modified the jenkins script to allow to test several pull requests at the same time. I am currently running the tests for #509, #600 and #601 here:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/276/console

@nclopezo
Copy link
Contributor

You can see the artifacts of the tests here:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/276

@ktf
Copy link
Contributor

ktf commented Aug 27, 2013

@apfeiffer1 the +1 needs to be in the first line and needs to be the only thing on it.

@apfeiffer1
Copy link
Contributor

@ktf ... if the +1 would mean approval of the PR -- which in this case it was intentionally not.
(As it's not really in my "domain", but in "alca"), I only +1'd the request for the merged test :)

PS: also in this mail the various "+1"s are not meant for approval, that's why they are where they are ;)

@demattia
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests.

ktf added a commit that referenced this pull request Aug 27, 2013
Alignment Packages  -- changes for large object passed by value
@ktf ktf merged commit 3841d21 into cms-sw:CMSSW_7_0_X Aug 27, 2013
@gartung gartung deleted the argsize-Alignment branch August 27, 2013 21:08
perrozzi pushed a commit to perrozzi/cmssw that referenced this pull request Jan 10, 2017
cmsbuild pushed a commit that referenced this pull request Dec 25, 2020
Address the pixel local reconstruction review comments.

General clean up of the pixel local reconstruction code:
  - update comments;
  - update data members for better consistency;
  - remove unimplemented method.
fwyzard added a commit to fwyzard/cmssw that referenced this pull request Dec 30, 2020
Address the pixel local reconstruction review comments.

General clean up of the pixel local reconstruction code:
  - update comments;
  - update data members for better consistency;
  - remove unimplemented method.
cmsbuild pushed a commit that referenced this pull request Jan 20, 2021
Address the pixel local reconstruction review comments.

General clean up of the pixel local reconstruction code:
  - update comments;
  - update data members for better consistency;
  - remove unimplemented method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants