-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alignment Packages -- changes for large object passed by value #599
Conversation
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_0_X. Alignment Packages -- changes for large object passed by value It involves the following packages: Alignment/CommonAlignment @demattia, @rcastello can you please review it and eventually sign? Thanks. |
…tic analyzer cms.ArgSizeChecker
Pull request #599 was updated. Signatures reset, please check and sign again. |
Would it be possible to have a round of tests? |
You can see the artifacts of the tests here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/276 |
@apfeiffer1 the +1 needs to be in the first line and needs to be the only thing on it. |
@ktf ... if the +1 would mean approval of the PR -- which in this case it was intentionally not. PS: also in this mail the various "+1"s are not meant for approval, that's why they are where they are ;) |
+1 |
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. |
Alignment Packages -- changes for large object passed by value
prepare crab scripts
Address the pixel local reconstruction review comments. General clean up of the pixel local reconstruction code: - update comments; - update data members for better consistency; - remove unimplemented method.
Address the pixel local reconstruction review comments. General clean up of the pixel local reconstruction code: - update comments; - update data members for better consistency; - remove unimplemented method.
Address the pixel local reconstruction review comments. General clean up of the pixel local reconstruction code: - update comments; - update data members for better consistency; - remove unimplemented method.
found by clang static analyzer cms.ArgSizeChecker