Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modifications to Razor trigger modules for Run 2 HLT #6036

Merged
merged 3 commits into from Oct 30, 2014

Conversation

jmduarte
Copy link
Member

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jmduarte (Javier Duarte) for CMSSW_7_3_X.

modifications to Razor trigger modules for Run 2 HLT

It involves the following packages:

HLTrigger/JetMET

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@@ -0,0 +1,14 @@
import FWCore.ParameterSet.Config as cms
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this cff file for?
We only use cfi files generated by fillDescriptions within HLTrigger!

@Martin-Grunewald
Copy link
Contributor

Remember to also make aPR for 72X.

@jmduarte jmduarte closed this Oct 28, 2014
@jmduarte jmduarte reopened this Oct 28, 2014
@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

-1

Please fix. Also, if you want to use it for trigger development,
we need a 72X PR as well.

@cmsbuild
Copy link
Contributor

Pull request #6036 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please check and sign again.

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Oct 30, 2014
modifications to Razor trigger modules for Run 2 HLT
@cmsbuild cmsbuild merged commit 3f7f7ae into cms-sw:CMSSW_7_3_X Oct 30, 2014
@jmduarte jmduarte deleted the razor-run2-hlt branch October 31, 2014 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants