Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct a typo in Ele32 path names #6068

Merged

Conversation

ebouvier
Copy link

This PR aims to correct a typo in Ele32* path names in the Top PAG validation codes.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ebouvier for CMSSW_7_2_X.

Correct a typo in Ele32 path names

It involves the following packages:

DQMOffline/Trigger
HLTriggerOffline/Top

@nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda can you please review it and eventually sign? Thanks.
@rociovilar, @abbiendi, @trocino, @battibass this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

-1
Tested at: dcd12ee
When I ran the RelVals I found an error in the following worklfows:
4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6068/463/summary.html

@ebouvier
Copy link
Author

Hi @cmsbuild,
This crash doesn't seem to be related to my changes. Could you please relaunch the tests ?

@cmsbuild
Copy link
Contributor

-1
Tested at: dcd12ee
When I ran the RelVals I found an error in the following worklfows:
4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6068/469/summary.html

@ebouvier
Copy link
Author

@cmsbuild,
That's still the same bug.

@deguio
Copy link
Contributor

deguio commented Oct 30, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @nclopezo, @ktf, @davidlange6, @smuzaffar

davidlange6 added a commit that referenced this pull request Oct 30, 2014
@davidlange6 davidlange6 merged commit 729590b into cms-sw:CMSSW_7_2_X Oct 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants