Remove makeModule from worker #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al module type Since module's are made separately from Workers it no longer made sense for the Worker to have a templated method used to construct the specific module type. This also means we no longer need the StreamWorker specialization.
Since all modules use edm::WorkerT now there is no need for the WorkerType typedef in the module base classes.
|
+1 The changed class and typedefs are only used internally in FWCore/Framework. |
|
@nclopezo Can you please run the usual set of tests? Thanks. |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. |
|
Hi, I started the tests, but I noticed that the script that jenkins generates was failing when no extra workflows were added to the short matrix tests. I started the tests again, you can see the logs here: |
perrozzi
pushed a commit
to perrozzi/cmssw
that referenced
this pull request
Jan 12, 2017
Various fixes for crab running
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that there is no longer a one-to-one correspondence between Workers and modules it no longer makes sense
to have the Worker define how a module should be made. That is now done via a MakeModuleHelper template which
can be specialized as needed. This now means that all Workers are just instances of edm::WorkerT.