Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace std::cout with LogDebug. #609

Merged
merged 1 commit into from
Aug 26, 2013
Merged

Replace std::cout with LogDebug. #609

merged 1 commit into from
Aug 26, 2013

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Aug 26, 2013

  • Replace std::cout with LogDebug
  • Remove commented out lines
  • Use LogWarning for reporting a problem

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna for CMSSW_7_0_X.

Replace std::cout with LogDebug.

It involves the following packages:

Geometry/CaloGeometry

@Dr15Jones, @ianna, @ktf can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

+1

@nclopezo can you please test it compiles fine (no need for other tests).

@nclopezo
Copy link
Contributor

Hi,

It compiles, you can see the logs here:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/247/console

cmsbuild added a commit that referenced this pull request Aug 26, 2013
@cmsbuild
Merge pull request #609 from ianna/replace-cout-with-logdebug
8c014a5 
Replace std::cout with LogDebug.
@cmsbuild cmsbuild merged commit 8c014a5 into cms-sw:CMSSW_7_0_X Aug 26, 2013
@ianna ianna deleted the replace-cout-with-logdebug branch October 26, 2015 16:33
cvernier pushed a commit to cvernier/cmssw that referenced this pull request Jan 12, 2017
@arizzi
Merge pull request cms-sw#609 from arizzi/crabJecfix
7513668 
fix EF payload
cmsbuild pushed a commit that referenced this pull request Mar 26, 2021
@ericcano
Clean up the pixel vertex reconstruction code (#609)
7a82e9e 
Split PixelVertexProducerCUDA produce() method into two methods, for running on the CPU and on the GPU.

Update access to EDM handles and event collections.

General code clean up:
  - use named constants for kernel grid dimensions;
  - replace commented out code with #ifdef-based conditionals;
  - update data member names to follow the coding rules;
  - fix include guard names and replace relative with absolute includes.

Apply code formatting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
geometry-pending pending-signatures
Projects
None yet
Milestone
CMSSW_7_0_0_pre3
Development

Successfully merging this pull request may close these issues.
3 participants
@ianna @cmsbuild @nclopezo