Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heppy integration 7 3 x #6115

Merged
merged 63 commits into from Nov 6, 2014
Merged

Heppy integration 7 3 x #6115

merged 63 commits into from Nov 6, 2014

Conversation

cbernet
Copy link
Contributor

@cbernet cbernet commented Oct 30, 2014

Added Heppy software framework to 7_3_X.

cbernet and others added 30 commits October 30, 2014 15:33
@cbernet
first integration of heppy in CMSSW
59ce52b
@cbernet
fwlite input working
320deb9
@cbernet
imported analysis code from CMGTools. JSONAnalyzer working
be7fae5
@cbernet
Jet analyzer working (b tagging SF commented)
06db110
@cbernet
re-enabled btagging
6fd3789
@cbernet
importing all physics objects except electrons
6c9be89
@arizzi @cbernet
move utility classes to dedicated physicsutils/ folder
acff8d0
@cbernet
added simple example
f4e3a4b
@cbernet
added jets to simple example
e317f00
@cbernet
updated imports after move to physicsutils
acd9c19
@cbernet
platform detection from input root file
16bd1a4
@arizzi @cbernet
create example subfolder
bfcd05d
@arizzi @cbernet
reorganize the structure, rename some classes, import some modules fr…
ce632d5 
…om SUSY/ttH analysis, many names to changes, all imports should still be fixed
@arizzi @cbernet
move to core
35fc353
@arizzi @cbernet
replace some imports
fdb8cac
@arizzi @cbernet
adapt names, change process() argument list
8a5ba08
@arizzi @cbernet
adapt event interface
281cb9a
@arizzi @cbernet
fix
2991933
@arizzi @cbernet
fix s
37a211b
@arizzi @cbernet
various fixes
dabef6e
@arizzi @cbernet
newest version of Tree(numpy) from Giovanni repo?
9185b33
@cbernet
class objects and events class now defined in configuration file by t…
def0db6 
…he user.
@cbernet
added unit test for the config module
f62af3b
@cbernet
added unit test for the config module
cd2a7b7
@cbernet
code clean up in JetAnalyzer
6d2f9e5
@cbernet
adapted to new configuration strategy (class objects and Events in cfg)
5a95f11
@cbernet
more cleaning in JetAnalyzer
7624c6e
@arizzi @cbernet
Vertex analyzer fix and import path fix
5b24138
@arizzi @cbernet
implement init.py and some renaming
fcd6df7
@arizzi @cbernet
implement init.py and some renaming
8d0f998
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2014

Pull request #6115 was updated. @cmsbuild, @vadler, @nclopezo, @monttj can you please check and sign again.

@vadler
Copy link

vadler commented Nov 6, 2014

+1
Tested with CMSSW_7_3_X_2014-11-06-0200.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2014

+1
Tested at: a18642c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6115/698/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Nov 6, 2014
@cmsbuild
Merge pull request #6115 from cbernet/heppy_integration_7_3_X
ea52241 
Heppy integration 7 3 x
@cmsbuild cmsbuild merged commit ea52241 into cms-sw:CMSSW_7_3_X Nov 6, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2014

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6115/698/summary.html

nclopezo
nclopezo reviewed Nov 10, 2014
View reviewed changes
PhysicsTools/Heppy/src/classes.h
heppy::TriggerBitChecker checker;
heppy::CMGMuonCleanerBySegmentsAlgo cmgMuonCleanerBySegmentsAlgo;
heppy::EGammaMvaEleEstimatorFWLite egMVA;
heppy::Hemisphere hemisphere(std::vector<float> px, std::vector<float> py, std::vector<float> pz, std::vector<float> E, int hemi_seed, int hemi_association);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is causing the warnings in the IBs: https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc491/CMSSW_7_3_X_2014-11-07-0200/PhysicsTools/Heppy

@nclopezo
Copy link
Contributor

Hi @cbernet,
This pull request caused the warnings that you can see here: https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc491/CMSSW_7_3_X_2014-11-07-0200/PhysicsTools/Heppy

Could you please clean them up?

@vadler
Copy link

vadler commented Nov 11, 2014

@nclopezo : Fixed in #6330 .

@cbernet cbernet deleted the heppy_integration_7_3_X branch November 21, 2014 09:23
@makortel makortel mentioned this pull request Jul 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved comparison-pending fully-signed tests-approved
Projects
None yet
Milestone
Next CMSSW_7_3_X
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@cbernet @cmsbuild @vadler @arizzi @slava77 @davidlange6 @nclopezo @BetterWang