Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing link dependency #6122

Merged
merged 1 commit into from
Oct 30, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Oct 30, 2014

Add missing link dependency. This fixes numerous link errors in the ROOT6 IB.
Please merge as soon as convenient.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_3_ROOT6_X.

Add missing link depemdency

It involves the following packages:

CondFormats/DTObjects

@apfeiffer1, @nclopezo, @cerminar, @cmsbuild, @diguida, @rcastello, @ggovi, @mmusich can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@wmtan wmtan changed the title Add missing link depemdency Add missing link dependency Oct 30, 2014
ktf added a commit that referenced this pull request Oct 30, 2014
@ktf ktf merged commit bd8d954 into cms-sw:CMSSW_7_3_ROOT6_X Oct 30, 2014
@ktf
Copy link
Contributor

ktf commented Oct 30, 2014

why not in vanilla 73x?

@wmtan
Copy link
Contributor Author

wmtan commented Oct 30, 2014

Giulio,
OK, I'll put it in vanilla 73x also.

@wmtan wmtan deleted the AddMissinglLinkDependency branch October 30, 2014 21:55
@apfeiffer1
Copy link
Contributor

+1

On Thu, Oct 30, 2014 at 10:02 PM, cmsbuild notifications@github.com wrote:

A new Pull Request was created by @wmtan https://github.com/wmtan for
CMSSW_7_3_ROOT6_X.

Add missing link depemdency

It involves the following packages:

CondFormats/DTObjects

@apfeiffer1 https://github.com/apfeiffer1, @nclopezo
https://github.com/nclopezo, @cerminar https://github.com/cerminar,
@cmsbuild https://github.com/cmsbuild, @diguida
https://github.com/diguida, @rcastello https://github.com/rcastello,
@ggovi https://github.com/ggovi, @mmusich https://github.com/mmusich
can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line
of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.


Reply to this email directly or view it on GitHub
#6122 (comment).

Thanks,
cheers, andreas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants