Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes for large object passed by value found by clang static analyzer cms.ArgSizeChecker #618

Merged
merged 1 commit into from
Aug 28, 2013

Conversation

gartung
Copy link
Member

@gartung gartung commented Aug 26, 2013

edm::ParameterSet is large

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_0_X.

changes for large object passed by value found by clang static analyzer cms.ArgSizeChecker

It involves the following packages:

HLTrigger/Egamma
HLTriggerOffline/SUSYBSM

@perrotta, @Martin-Grunewald, @rovere, @deguio, @fwyzard can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@fwyzard
Copy link
Contributor

fwyzard commented Aug 26, 2013

+1

@cmsbuild
Copy link
Contributor

The following categories have been signed by @fwyzard: HLT

@cms-git-hlt

@fwyzard
Copy link
Contributor

fwyzard commented Aug 26, 2013

mhm, the "+1" didn't seem to work, so I've signed it in the TC :)

@cmsbuild
Copy link
Contributor

The following categories have been signed by @rovere: DQM

@cms-git-dqm

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests.

@ktf
Copy link
Contributor

ktf commented Aug 28, 2013

@nclopezo can you try this out?

@nclopezo
Copy link
Contributor

Hi,

I ran the tests on top of CMSSW_6_2_X_2013-08-28-0200, all tests passed

The logs are here:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/304/console

and the artifacts here:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/297/

@ktf
Copy link
Contributor

ktf commented Aug 28, 2013

you mean CMSSW_7_0_X_2013-08-28-0200, right?

ktf added a commit that referenced this pull request Aug 28, 2013
changes for large object passed by value found by clang static analyzer cms.ArgSizeChecker
@ktf ktf merged commit f3efe26 into cms-sw:CMSSW_7_0_X Aug 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants