Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LumiInfo classes for Run 2 luminosity information #6204

Merged
merged 14 commits into from
Nov 6, 2014

Conversation

plujan
Copy link
Contributor

@plujan plujan commented Nov 4, 2014

This contains the new LumiInfo, LumiInfoRunHeader, and BeamCurrentInfo classes which will be used to store the Run2 lumi information. This is an update of PR #5314 which fixes the issues raised there. LumiInfoRunHeader now uses std::bitset to store the filling scheme information, and the beam intensities are now stored in 16 bits. This uses libminifloat, which is currently in DataFormats/PatCandidates -- it might be useful to move it to some central location.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2014

A new Pull Request was created by @plujan for CMSSW_7_3_X.

LumiInfo classes for Run 2 luminosity information

It involves the following packages:

DataFormats/Luminosity

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2014

@StoyanStoynev
Copy link
Contributor

+1
Tested 428a375 on top CMSSW_7_3_X_2014-11-04-0200 . No diffs in shortm matrix tests and none expected. This PR just introduces the initial version of the new lumi data format. May get small modifications while developing the rest of the code (in next days/weeks).

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Nov 6, 2014
LumiInfo classes for Run 2 luminosity information
@cmsbuild cmsbuild merged commit 10be8ef into cms-sw:CMSSW_7_3_X Nov 6, 2014
@plujan plujan deleted the lumiInfo-run-2 branch November 6, 2014 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants