Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filter for ecal_ and collection names for ecal_, ecalcalib_ #6320

Merged
merged 2 commits into from
Nov 18, 2014
Merged

Fix filter for ecal_ and collection names for ecal_, ecalcalib_ #6320

merged 2 commits into from
Nov 18, 2014

Conversation

yiiyama
Copy link
Contributor

@yiiyama yiiyama commented Nov 11, 2014

This is intended to be a quick fix for tonight. There is still an unsolved (less important) issue.
Thank you!

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @yiiyama (Yutaro Iiyama) for CMSSW_7_2_X.

Fix filter for ecal_ and collection names for ecal_, ecalcalib_

It involves the following packages:

DQM/Integration

@nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda can you please review it and eventually sign? Thanks.
@batinkov this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Nov 11, 2014

this fixes a problem in the ecal online configuration. the same fix should be submitted to 73. waiting to see it there before approving.
thanks @yiiyama @danduggan

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 18, 2014
Fix filter for ecal_ and collection names for ecal_, ecalcalib_
@cmsbuild cmsbuild merged commit 540c982 into cms-sw:CMSSW_7_2_X Nov 18, 2014
@yiiyama yiiyama deleted the ecaldqm-online-config-fix branch October 7, 2015 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants