edmPluginHelp: differentiate thread-safe legacy modules

[fwyzard]

For EDAnalyzers, EDProducers, and EDFilters, let ParameterSetDescriptionFiller check at compile time for global vs. stream vs. one vs. legacy modules, and return the appropriate description via extendedBaseType().

Make edmPluginHelp check for, and print, the extendedBaseType.

[fwyzard]

Note that I've pushed this while still re-building most of CMSSW to test if it actually works...

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_3_X.

edmPluginHelp: differentiate thread-safe legacy modules

It involves the following packages:

FWCore/ParameterSet

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests.

[fwyzard]

OK, seems to work for me:

$ edmPluginHelp -a -q | head -n20
       Plugin Name                                       Plugin Type             Library Name
       -----------                                       -----------             ------------
1      AMPTAnalyzer                                      EDAnalyzer              "pluginAMPTAnalyzer.so"
2      AMPTGeneratorFilter                               one::EDFilter           "pluginGeneratorInterfaceAMPTInterfacePlugins.so"
3      APVCyclePhaseMonitor                              EDAnalyzer              "pluginDPGAnalysisSiStripToolsPlugins.so"
4      APVCyclePhaseProducerFromL1ABC                    EDProducer              "pluginDPGAnalysisSiStripToolsPlugins.so"
5      APVCyclePhaseProducerFromL1TS                     EDProducer              "pluginDPGAnalysisSiStripToolsPlugins.so"
6      APVShotsAnalyzer                                  EDAnalyzer              "pluginDPGAnalysisSiStripToolsPlugins.so"
7      APVShotsFilter                                    EDFilter                "pluginDPGAnalysisSiStripToolsPlugins.so"
8      APVValidationPlots                                EDAnalyzer              "pluginDQMOfflineCalibTracker.so"
9      AVSimpleProducer                                  stream::EDProducer      "pluginTestToyModules.so"
10     AbortOnEventIDAnalyzer                            EDAnalyzer              "pluginFWCoreModules.so"
11     AcceptanceHistoProducer                           EDAnalyzer              "pluginTauAnalysisMCEmbeddingToolsPlugins.so"
12     AdaptorConfig                                     Service                 "pluginIOPoolTFileAdaptor.so"
13     AddCorrectionsToCaloMET                           EDProducer              "pluginJetMETCorrectionsType1MET_plugins.so"
14     AddCorrectionsToPFMET                             EDProducer              "pluginJetMETCorrectionsType1MET_plugins.so"
15     AddIntsProducer                                   EDProducer              "pluginTestToyModules.so"
16     AlCaDiJetsProducer                                EDProducer              "pluginCalibrationHcalAlCaRecoProducers.so"
17     AlCaECALRecHitReducer                             EDProducer              "pluginCalibrationEcalAlCaRecoProducers.so"
18     AlCaEcalHcalReadoutsProducer                      EDProducer              "pluginCalibrationHcalAlCaRecoProducers.so"

[cmsbuild]

-1

Tested at: 0b4b30b
I ran the usual tests and I found errors in the following unit tests:

---> test TestIntegrationParameterSet had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6383/868/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (but tests are reportedly failing).

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (but tests are reportedly failing).

[fwyzard]

Now I've updated the expected output for the unit tests, too.

[fwyzard]

Bot, can you test again ?

[cmsbuild]

Pull request #6383 was updated. @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please check and sign again.

[cmsbuild]

@fwyzard sure!

[cmsbuild]

+1
Tested at: 70afff4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6383/887/summary.html

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6383/887/summary.html