Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templated additional b taggers #6393

Conversation

ferencek
Copy link
Contributor

This PR templates track counting, jet probability, and simple secondary vertex taggers and adds their candidate-based instances. New taggers are also propagated to PAT.

The changes should be completely transparent to Reco as can be seen in the following three plots produced by running over 1k ttbar events:

TCHE
performance_tche

JP
performance_jp

SSVHE
performance_ssvhe

For reference, also adding performance plots for the candidate-based taggers:

pfTCHE
performance_pftche

pfJP
performance_pfjp

pfSSVHE
performance_pfssvhe

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_3_X.

Templated additional b taggers

It involves the following packages:

PhysicsTools/PatAlgos
RecoBTag/ImpactParameter
RecoBTag/SecondaryVertex

@nclopezo, @monttj, @cmsbuild, @StoyanStoynev, @slava77, @vadler can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @acaudron, @mmarionncern, @nhanvtran, @schoef, @ferencek, @mariadalfonso, @pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@vadler
Copy link

vadler commented Nov 14, 2014

+1
Tested with CMSSW_7_3_X_2014-11-14-0200.
Only additions of new algos at AT level, which run fine in PhysicsTools/PatAlgos/test(patTuple_addBTagging_cfg.py

@slava77
Copy link
Contributor

slava77 commented Nov 14, 2014

+1

for #6393 b215cc0
tested in CMSSW_7_3_X_2014-11-13-1400 (test area sign461)
The standard RECO outputs are unchanged.
This includes no changes in the pfImpactParameterTagInfos and pfSecondaryVertexTagInfos candidate-based taggers running in RECO.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Nov 14, 2014
…-CMSSW_7_3_0_pre2

Templated additional b taggers
@cmsbuild cmsbuild merged commit ed638a6 into cms-sw:CMSSW_7_3_X Nov 14, 2014
@ferencek ferencek deleted the TemplatedNonCSVTaggers_from-CMSSW_7_3_0_pre2 branch November 14, 2014 15:59
@ferencek ferencek restored the TemplatedNonCSVTaggers_from-CMSSW_7_3_0_pre2 branch November 14, 2014 15:59
@ferencek ferencek deleted the TemplatedNonCSVTaggers_from-CMSSW_7_3_0_pre2 branch December 24, 2014 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants