Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build a vector applying a transformation to each element of an input vector #648

Merged
merged 4 commits into from
Sep 2, 2013

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Aug 28, 2013

helper template function to build a vector by applying a transformation function to each elements of an input vector

  • return type deduction by @makortel
  • reference and cv-qualified return types should be properly handled

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_0_X.

build a vector applying a transformation to each element of an input vector

It involves the following packages:

FWCore/Utilities

@Dr15Jones, @ktf can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@Dr15Jones
Copy link
Contributor

+1

@Dr15Jones
Copy link
Contributor

It would have been nice had a unit test been made to prove that this works as expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests.

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 29, 2013

Hi Chris,
I do have some tests using this (along with consumes / mayConsume, etc.) that I've written to figure out the sequence of "events" whe using scheduled and unscheduled execution.

However, I do not know how to write a proper "unit test" - if you can point me to an example, I can add one for vector_transform.

.A

@Dr15Jones
Copy link
Contributor

Try one of the .cppunit.cpp tests in FWCore/Utilities/test. E.g. soatuple_t.cppunit.cpp

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 29, 2013

OK, I've added a unit test.

@cmsbuild
Copy link
Contributor

Pull request #648 was updated. Signatures reset, please check and sign again.

@Dr15Jones
Copy link
Contributor

+1
Thanks for the test

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests.

davidlt added a commit that referenced this pull request Sep 2, 2013
build a vector applying a transformation to each element of an input vector
@davidlt davidlt merged commit e9fe97b into cms-sw:CMSSW_7_0_X Sep 2, 2013
cheidegg pushed a commit to cheidegg/cmssw that referenced this pull request Jun 15, 2016
veelken pushed a commit to veelken/cmssw that referenced this pull request Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants