Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MuonAnalysis/MuonAssociators gen particle migration #649

Conversation

gpetruc
Copy link
Contributor

@gpetruc gpetruc commented Aug 28, 2013

Done the migration from HepMC::GenParticle to reco::GenParticle
Seems like it works, also on GEN-SIM-RECO with the TP's on the fly without simHits

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gpetruc for CMSSW_7_0_X.

MuonAnalysis/MuonAssociators gen particle migration

It involves the following packages:

MuonAnalysis/MuonAssociators

@vadler can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@ktf
Copy link
Contributor

ktf commented Aug 28, 2013

@nclopezo can you please test this? Thanks.

@nclopezo
Copy link
Contributor

Hi,

I ran the tests on top of CMSSW_7_0_X_2013-08-28-0200, all tests passed

You can see the logs here:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/302/consoleFull

And the artifacts can be seen here:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/302/

@vadler
Copy link

vadler commented Aug 28, 2013

+1
Tested on top of CMSSW_7_0_X_2013-08-28-1400

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests.

ktf added a commit that referenced this pull request Aug 28, 2013
…Particle-migration

MuonAnalysis/MuonAssociators gen particle migration
@ktf ktf merged commit a9af9d7 into cms-sw:CMSSW_7_0_X Aug 28, 2013
@gpetruc gpetruc deleted the MuonAnalysis-MuonAssociators_genParticle-migration branch June 1, 2016 07:48
jpata pushed a commit to jpata/cmssw that referenced this pull request Jun 16, 2016
Updated PhotonID bits and updated Jet PU ID (76X WP tuning)
cvernier pushed a commit to cvernier/cmssw that referenced this pull request Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants