-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch for name space bug #657
Conversation
A new Pull Request was created by @inugent for CMSSW_7_0_X. Patch for name space bug It involves the following packages: GeneratorInterface/ExternalDecays @vciulli can you please review it and eventually sign? Thanks. |
@nclopezo can you please test this? |
@@ -118,7 +118,7 @@ int readParticlesFromHepMC(const HepMC::GenEvent *event, SimpleParticle &X, Simp | |||
else if(!hTau2) hTau2 = *it2; | |||
else | |||
{ | |||
cout<<"TauSpiner: three taus in one decay"<<endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, you should probably use LogError / LogWarning / LogInfo as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
Ok this should be fixed now. The pull request is automatically
updated. Best regards,
Ian
On 8/29/2013 3:03 PM, Giulio Eulisse wrote:
In GeneratorInterface/ExternalDecays/src/read_particles_from_HepMC.cc:
@@ -118,7 +118,7 @@ int readParticlesFromHepMC(const HepMC::GenEvent *event, SimpleParticle &X, Simp
else if(!hTau2) hTau2 = *it2;
else
{
cout<<"TauSpiner: three taus in one decay"<<endl;
BTW, you should probably use LogError / LogWarning / LogInfo as well.
—
Reply to this email directly or view it on GitHub
https://github.com/cms-sw/cmssw/pull/657/files#r6059449.
Dr. Ian M. Nugent
Humboldt Fellow
III. Physikalisches Institut B
RWTH Aachen, D-52056 Aachen
Tel: +49 241 80-27290
Email: nugent@physik.rwth-aachen.de
Pull request #657 was updated. Signatures reset, please check and sign again. |
Hi, I ran the tests on top of CMSSW_7_0_X_2013-08-29-0200, all tests passed The logs are here: and the artifacts here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/314/ |
Technical fix. Bypassing @vciulli signature. |
No description provided.