Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread safety improvement BeamHaloProducer #6675

Merged
merged 1 commit into from
Dec 15, 2014
Merged

Thread safety improvement BeamHaloProducer #6675

merged 1 commit into from
Dec 15, 2014

Conversation

cmsbuild
Copy link
Contributor

This adds a declaration of a SharedResource to the
BeamHaloProducer. The shared resources are global
variables the module uses. This ensures thread safety
in the case where multiple BeamHaloProducers are run
in the same job (practically speaking this probably
never happens).

More importantly, the static code analyzer reported a
thread safety problem. A future version of the static
analyzer will not report the problem if
BeamHaloProducer is a one module with a shared resource.
So this should eliminate the warning.
Automatically ported from CMSSW_7_3_X #6414

@wddgit
Thread safety improvement BeamHaloProducer
8cb9528 
This adds declaration of a SharedResource to the
BeamHaloProducer. The shared resources are global
variables the module uses. This ensures thread safety
in the case where multiple BeamHaloProducers are run
in the same job (practically speaking this probably
never happens).

More importantly, the static code analyzer reported a
thread safety problem. A future version of the static
analyzer will not report the problem if
BeamHaloProducer is a one module with a shared resource.
So this should eliminate the warning.
@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Nov 27, 2014
@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_7_4_X.

Thread safety improvement BeamHaloProducer

It involves the following packages:

GeneratorInterface/BeamHaloGenerator

@vciulli, @covarell, @thuer, @cmsbuild, @nclopezo, @bendavid can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@ktf ktf mentioned this pull request Nov 27, 2014
Closed
@nclopezo
Copy link
Contributor

+1
Latest commit marked as "Tests OK" in CMSSW_7_3_X

@davidlange6
Copy link
Contributor

is this PR obsolete? Seems to trivial to be pending for two weeks

@bendavid
Copy link
Contributor

+1
(we're just behind on pull requests)

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Dec 15, 2014
@cmsbuild
Merge pull request #6675 from wddgit/threadBeamHaloProducer
27700ec 
Thread safety improvement BeamHaloProducer
@cmsbuild cmsbuild merged commit 27700ec into cms-sw:CMSSW_7_4_X Dec 15, 2014
@wddgit wddgit deleted the threadBeamHaloProducer branch February 4, 2015 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending fully-signed generators-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.
5 participants
@cmsbuild @nclopezo @davidlange6 @bendavid @wddgit