Don't use removed header #6867
Merged
Don't use removed header #6867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @wmtan for CMSSW_7_4_ROOT6_X. Don't use removed header It involves the following packages: CondCore/ORA @ggovi, @cmsbuild, @apfeiffer1, @nclopezo can you please review it and eventually sign? Thanks. |
|
ping |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent fix for the remaining CondCore unit test failures removed the header oraHelper.h, which was still used by one other unit test. This pull request fixes that unit test to not use the removed header, thereby fixing what would otherwise be a build error. The unit test still passes with this change.
Please merge as soon as convenient, if possible in time for the next IB.