Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ak4 gen and PF jets to corresponding sequences #6907

Merged
merged 2 commits into from Dec 15, 2014

Conversation

fratnikov
Copy link

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fratnikov (Fedor Ratnikov) for CMSSW_6_2_X_SLHC.

add ak4 gen and PF jets to corresponding sequences

It involves the following packages:

RecoJets/Configuration

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @TaiSakuma, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #6907 was updated. @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

@mark-grimes
Copy link

merge

cmsbuild added a commit that referenced this pull request Dec 15, 2014
add ak4 gen and PF jets to corresponding sequences
@cmsbuild cmsbuild merged commit 8ec9c82 into cms-sw:CMSSW_6_2_X_SLHC Dec 15, 2014
@boudoul
Copy link
Contributor

boudoul commented Dec 16, 2014

Hi @fratnikov , do we know the impact of the ressources (memory , timing) at high PU ? I'm worried because for HGCal we are trying to reduce the reco step , and also we are just about to send big digi-reco prodcution for Shaslik, so i'm worried that this is inducing resosurces while we are already at the limit (or even already above..) .

@fratnikov
Copy link
Author

@boudoul: we currently produce 35 Jet collections in RECO (see below),
22 PFJets, 5 GenJets, 6 CaloJets, 2 BasicJets. However neither of them
is considered as reference for Jet/MET performance studies, so people re-reconstruct
AK4 jets privately to get reference objects and work from them.

Very conservative estimation is that adding 3 more Jet collections to 35 already available
won't increase total jet reconstruction footprint by more than 10%.
This is PU invariant estimation, and total jet reconstruction is likely not the primary
resource waster.

However, if resources is big an issue requiring action, we can safely drop all jet collections
except AK5 and KT6, as other jets are dedicated for higher level analyses which are
not feasible until basic Jet reconstruction i.e. AK4 jets are established.

recoPFJets_kt4PFJets__RECO.
recoPFJets_ak5PFJets__RECO.
recoCaloJets_kt4CaloJets__RECO.
recoPFJets_iterativeCone5PFJets__RECO.
recoPFJets_kt6PFJets__RECO.
recoPFJets_ak8PFJets__RECO.
recoCaloJets_ak5CaloJets__RECO.
recoCaloJets_iterativeCone5CaloJets__RECO.
recoPFJets_ak5PFJetsCHS__RECO.
recoCaloJets_kt6CaloJets__RECO.
recoCaloJets_kt6CaloJetsCentral__RECO.
recoPFJets_ca8PFJetsCHSPruned_SubJets_RECO.
recoPFJets_kinematicSelectedPFJets__RECO.
recoPFJets_PFJetsId__RECO.
recoIsoDepositedmValueMap_muIsoDepositJets__RECO.
recoCaloJets_ak7CaloJets__RECO.
recoPFJets_ca8PFJetsCHS__RECO.
recoPFJets_ak8PFJetsCHS__RECO.
recoPFJets_kt6PFJetsCentralChargedPileUp__RECO.
recoRecoChargedRefCandidates_trackRefsForJets__RECO.
recoPFJets_cmsTopTagPFJetsCHS_caTopSubJets_RECO.
recoPFJets_ak8PFJetsCHSConstituents__RECO.
recoTrackJets_ak5TrackJets__RECO.
recoPFJets_kt6PFJetsCentralNeutral__RECO.
recoPFJets_ca15PFJetsCHSFiltered_SubJets_RECO.
recoPFJets_ca15PFJetsCHSMassDropFiltered_SubJets_RECO.
recoJPTJets_JetPlusTrackZSPCorJetAntiKt5__RECO.
recoPFJets_kt6PFJetsCentralNeutralTight__RECO.
recoPFJets_hepTopTagPFJetsCHS_caTopSubJets_RECO.
recoGenJets_ak8GenJets__SIM.
recoGenJets_kt6GenJets__SIM.
recoGenJets_ak5GenJets__SIM.
recoGenJets_iterativeCone5GenJets__SIM.
recoBasicJets_ca8PFJetsCHSPruned__RECO.
recoGenJets_kt4GenJets__SIM.
recoBasicJets_cmsTopTagPFJetsCHS__RECO.

@davidlange6
Copy link
Contributor

indeed, there are memory problems..

perhaps removing some of the unneeded jets would benefit everyone

On Dec 16, 2014, at 4:41 PM, Fedor Ratnikov notifications@github.com
wrote:

@boudoul: we currently produce 35 Jet collections in RECO (see below),
22 PFJets, 5 GenJets, 6 CaloJets, 2 BasicJets. However neither of them
is considered as reference for Jet/MET performance studies, so people re-reconstruct
AK4 jets privately to get reference objects and work from them.

Very conservative estimation is that adding 3 more Jet collections to 35 already available
won't increase total jet reconstruction footprint by more than 10%.
This is PU invariant estimation, and total jet reconstruction is likely not the primary
resource waster.

However, if resources is big an issue requiring action, we can safely drop all jet collections
except AK5 and KT6, as other jets are dedicated for higher level analyses which are
not feasible until basic Jet reconstruction i.e. AK4 jets are established.

recoPFJets_kt4PFJets__RECO.
recoPFJets_ak5PFJets__RECO.
recoCaloJets_kt4CaloJets__RECO.
recoPFJets_iterativeCone5PFJets__RECO.
recoPFJets_kt6PFJets__RECO.
recoPFJets_ak8PFJets__RECO.
recoCaloJets_ak5CaloJets__RECO.
recoCaloJets_iterativeCone5CaloJets__RECO.
recoPFJets_ak5PFJetsCHS__RECO.
recoCaloJets_kt6CaloJets__RECO.
recoCaloJets_kt6CaloJetsCentral__RECO.
recoPFJets_ca8PFJetsCHSPruned_SubJets_RECO.
recoPFJets_kinematicSelectedPFJets__RECO.
recoPFJets_PFJetsId__RECO.
recoIsoDepositedmValueMap_muIsoDepositJets__RECO.
recoCaloJets_ak7CaloJets__RECO.
recoPFJets_ca8PFJetsCHS__RECO.
recoPFJets_ak8PFJetsCHS__RECO.
recoPFJets_kt6PFJetsCentralChargedPileUp__RECO.
recoRecoChargedRefCandidates_trackRefsForJets__RECO.
recoPFJets_cmsTopTagPFJetsCHS_caTopSubJets_RECO.
recoPFJets_ak8PFJetsCHSConstituents__RECO.
recoTrackJets_ak5TrackJets__RECO.
recoPFJets_kt6PFJetsCentralNeutral__RECO.
recoPFJets_ca15PFJetsCHSFiltered_SubJets_RECO.
recoPFJets_ca15PFJetsCHSMassDropFiltered_SubJets_RECO.
recoJPTJets_JetPlusTrackZSPCorJetAntiKt5__RECO.
recoPFJets_kt6PFJetsCentralNeutralTight__RECO.
recoPFJets_hepTopTagPFJetsCHS_caTopSubJets_RECO.
recoGenJets_ak8GenJets__SIM.
recoGenJets_kt6GenJets__SIM.
recoGenJets_ak5GenJets__SIM.
recoGenJets_iterativeCone5GenJets__SIM.
recoBasicJets_ca8PFJetsCHSPruned__RECO.
recoGenJets_kt4GenJets__SIM.
recoBasicJets_cmsTopTagPFJetsCHS__RECO.


Reply to this email directly or view it on GitHub.

@fratnikov
Copy link
Author

@davidlange6 If you talk about RAM shortage, then reducing number of jet collections won't help: jet reconstruction memory consumption is driven by number of input objects, which is pretty the same for all used jet algorithms of given flavor. So I expect no difference in peak RAM consumption between running one jet algorithm and running many of them sequentially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants