Add array dimension information #7017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @wmtan for CMSSW_7_4_ROOT6_X. Add array dimension informtion It involves the following packages: FWCore/Utilities @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
davidlt
added a commit
that referenced
this pull request
Dec 28, 2014
Add array dimension informtion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to update TypeWithDict so that it can handle C-style arrays without resorting to header parsing, it is necessary to add the array dimension information to TypeWithDict. This pull request simply adds the new data member. It does not actually use it yet.
It is convenient to add the data member separately, because modifying TypeWithDict.h here causes over 820 packages to rebuild. Once this request is in an IB, the feature can then be developed and tested without further modifying a header file.
Please merge this tivial request as soon as convenient.