Bugfix in event filtering

[osschar]

• Fireworks/Core/interface/FWRepresentationInfo.h
  • Initialize m_requiresFF in full ctor.
• Fireworks/Core/src/FWFileEntry.cc
  • Use proper edm::Wrapper typeid when asking fwlite::Event for branch name (by Chris). This fixes a bug that basically made event content and navigation random after one tried to enable filters.
  • Cleanup surrounding code:
    • Use a map to store previous branch addresses.
    • Only do branch-name query and regex_replace for matching collections.

[osschar]

+1

[cmsbuild]

A new Pull Request was created by @osschar (Matevž Tadel) for CMSSW_7_4_X.

Bugfix in event filtering

It involves the following packages:

Fireworks/Core

@cmsbuild, @alja, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[ktf]

please test
On mar 30 dic 2014 at 23:54 cmsbuild notifications@github.com wrote:

A new Pull Request was created by @osschar https://github.com/osschar
(Matevž Tadel) for CMSSW_7_4_X.

Bugfix in event filtering

It involves the following packages:

Fireworks/Core

@cmsbuild https://github.com/cmsbuild, @alja https://github.com/alja,
@Dr15Jones https://github.com/Dr15Jones, @ktf https://github.com/ktf,
@nclopezo https://github.com/nclopezo can you please review it and
eventually sign? Thanks.
@alja https://github.com/alja this is something you requested to watch
as well.
You can sign-off by replying to this message having '+1' in the first line
of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.

—
Reply to this email directly or view it on GitHub
#7027 (comment).

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 11ce4ae
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7027/1731/summary.html

[ktf]

+1
On Wed 31 Dec 2014 at 13:09 cmsbuild notifications@github.com wrote:

+1
Tested at: 11ce4ae
11ce4ae

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7027/1731/summary.html

—
Reply to this email directly or view it on GitHub
#7027 (comment).

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.