Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes to #6956 (Fast timing shashlik) #7053

Merged
merged 14 commits into from
Jan 6, 2015

Conversation

mark-grimes
Copy link

This is #6956 with some minor changes for integration:

  • Removed the geometry scenario added to test Shashlik without tracker. Don't want to expand the number of geometries unless necessary.
  • Changed the python printouts to be python comments in case output is piped to a new file, e.g. with edmConfigDump. Arguably these printouts should be removed completely but they can stay for now.
  • Added back a preprocessor conditional to suppress debug output.

@ptraczyk could you check these changes and comment if they're okay? You can see just my changes to yours at mark-grimes/cmssw@ptraczyk:FastTimingShashlik...mark-grimes:modify6956.

Details about the original intention of the pull request are on #6956.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2015

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Small changes to #6956 (Fast timing shashlik)

It involves the following packages:

RecoLocalCalo/EcalRecProducers
SLHCUpgradeSimulations/Configuration
SimCalorimetry/EcalSimAlgos
SimCalorimetry/EcalSimProducers
SimG4CMS/Calo
SimG4Core/Application

@civanch, @nclopezo, @mdhildreth, @cmsbuild, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @makortel, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ptraczyk
Copy link
Contributor

ptraczyk commented Jan 6, 2015

yes, I'm ok with all these, thanks for the cleanup!

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2015

@mark-grimes
Copy link
Author

merge

cmsbuild added a commit that referenced this pull request Jan 6, 2015
Small changes to #6956 (Fast timing shashlik)
@cmsbuild cmsbuild merged commit ce63c3e into cms-sw:CMSSW_6_2_X_SLHC Jan 6, 2015
@mark-grimes mark-grimes deleted the modify6956 branch January 23, 2015 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants