Backport in 73X of "Update of VBF HLT filter #7079 "

[silviodonato]

Backport in 73X of "Update of VBF HLT filter #7079 "

[cmsbuild]

A new Pull Request was created by @silviodonato for CMSSW_7_3_X.

Backport in 73X of "Update of VBF HLT filter #7079 "

It involves the following packages:

HLTrigger/JetMET

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[Martin-Grunewald]

-1
A crash when testing:

A fatal system signal has occurred: segmentation violation
The following is the call stack containing the origin of the signal.
NOTE:The first few functions on the stack are artifacts of processing the signal and can be ignored

#0  0x00000035edeac61e in waitpid () from /lib64/libc.so.6
#1  0x00000035ede3e609 in do_system () from /lib64/libc.so.6
#2  0x00007ffe74bcafb7 in TUnixSystem::StackTrace() () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_3_X_2015-01-08-0200/external/slc6_amd64_gcc491/lib/libCore.so
#3  0x00007ffe696e8ee5 in sig_dostack_then_abort () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_3_X_2015-01-04-1400/lib/slc6_amd64_gcc491/libFWCoreServices.so
#4  <signal handler called>
#5  0x00007ffe530a69f4 in edm::RefToBase<reco::Jet>::key (this=0x7ffe07b984f0) at /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_3_X_2015-01-08-0200/src/DataFormats/Common/interface/RefToBase.h:235
#6  0x00007ffe5309f20d in HLTJetSortedVBFFilter<reco::PFJet>::hltFilter (this=0x7ffe4919ae40, event=..., setup=..., filterproduct=...) at /scratch/CMS3/CMSSW_7_3_X_2015-01-08-0200/src/HLTrigger/JetMET/src/HLTJetSortedVBFFilter.cc:233
#7  0x00007ffe5c1e5711 in HLTFilter::filter(edm::StreamID, edm::Event&, edm::EventSetup const&) const () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_3_X_2015-01-04-1400/lib/slc6_amd64_gcc491/libHLTriggerHLTcore.so
#8  0x00007ffe7611a068 in edm::global::EDFilterBase::doEvent(edm::EventPrincipal&, edm::EventSetup const&, edm::ActivityRegistry*, edm::ModuleCallingContext const*) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_3_X_2015-01-04-1400/lib/slc6_amd64_gcc491/libFWCoreFramework.so
#9  0x00007ffe76117cdf in edm::WorkerT<edm::global::EDFilterBase>::implDo(edm::EventPrincipal&, edm::EventSetup const&, edm::ModuleCallingContext const*) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_3_X_2015-01-04-1400/lib/slc6_amd64_gcc491/libFWCoreFramework.so

Please test and fix, also the 74X PR.

[cmsbuild]

+1
Tested at: 259bf58
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7081/1776/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7081/1830/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

[davidlange6]

would be much better to convert value_ into an enum of sorts as to avoid several string comparisons per jets

[davidlange6]

+1
(comment should be considered later)