Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport in 73X of "Update of VBF HLT filter #7079 " #7081

Merged
merged 11 commits into from
Jan 14, 2015
Merged

Backport in 73X of "Update of VBF HLT filter #7079 " #7081

merged 11 commits into from
Jan 14, 2015

Conversation

silviodonato
Copy link
Contributor

Backport in 73X of "Update of VBF HLT filter #7079 "

@cmsbuild cmsbuild added this to the Next CMSSW_7_3_X milestone Jan 8, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2015

A new Pull Request was created by @silviodonato for CMSSW_7_3_X.

Backport in 73X of "Update of VBF HLT filter #7079 "

It involves the following packages:

HLTrigger/JetMET

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor

-1
A crash when testing:

A fatal system signal has occurred: segmentation violation
The following is the call stack containing the origin of the signal.
NOTE:The first few functions on the stack are artifacts of processing the signal and can be ignored

#0  0x00000035edeac61e in waitpid () from /lib64/libc.so.6
#1  0x00000035ede3e609 in do_system () from /lib64/libc.so.6
#2  0x00007ffe74bcafb7 in TUnixSystem::StackTrace() () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_3_X_2015-01-08-0200/external/slc6_amd64_gcc491/lib/libCore.so
#3  0x00007ffe696e8ee5 in sig_dostack_then_abort () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_3_X_2015-01-04-1400/lib/slc6_amd64_gcc491/libFWCoreServices.so
#4  <signal handler called>
#5  0x00007ffe530a69f4 in edm::RefToBase<reco::Jet>::key (this=0x7ffe07b984f0) at /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_3_X_2015-01-08-0200/src/DataFormats/Common/interface/RefToBase.h:235
#6  0x00007ffe5309f20d in HLTJetSortedVBFFilter<reco::PFJet>::hltFilter (this=0x7ffe4919ae40, event=..., setup=..., filterproduct=...) at /scratch/CMS3/CMSSW_7_3_X_2015-01-08-0200/src/HLTrigger/JetMET/src/HLTJetSortedVBFFilter.cc:233
#7  0x00007ffe5c1e5711 in HLTFilter::filter(edm::StreamID, edm::Event&, edm::EventSetup const&) const () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_3_X_2015-01-04-1400/lib/slc6_amd64_gcc491/libHLTriggerHLTcore.so
#8  0x00007ffe7611a068 in edm::global::EDFilterBase::doEvent(edm::EventPrincipal&, edm::EventSetup const&, edm::ActivityRegistry*, edm::ModuleCallingContext const*) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_3_X_2015-01-04-1400/lib/slc6_amd64_gcc491/libFWCoreFramework.so
#9  0x00007ffe76117cdf in edm::WorkerT<edm::global::EDFilterBase>::implDo(edm::EventPrincipal&, edm::EventSetup const&, edm::ModuleCallingContext const*) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_3_X_2015-01-04-1400/lib/slc6_amd64_gcc491/libFWCoreFramework.so

Please test and fix, also the 74X PR.

@Martin-Grunewald Martin-Grunewald mentioned this pull request Jan 8, 2015
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2015

+1
Tested at: 259bf58
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7081/1776/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7081/1830/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

davidlange6
davidlange6 reviewed Jan 14, 2015
View reviewed changes
HLTrigger/JetMET/src/HLTJetSortedVBFFilter.cc
Particle::LorentzVector b1,b2,q1,q2;
if (inputJetTags_.encode()=="") {
for (typename TCollection::const_iterator jet=jets->begin(); (jet!=jets->end()&& nJet<nMax); ++jet) {
if (value_=="Pt") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be much better to convert value_ into an enum of sorts as to avoid several string comparisons per jets

@davidlange6
Copy link
Contributor

+1
(comment should be considered later)

cmsbuild added a commit that referenced this pull request Jan 14, 2015
@cmsbuild
Merge pull request #7081 from silviodonato/VBFHbb_73X
0663bd8 
Backport in 73X of "Update of VBF HLT filter #7079 "
@cmsbuild cmsbuild merged commit 0663bd8 into cms-sw:CMSSW_7_3_X Jan 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed hlt-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_7_3_X
Development

Successfully merging this pull request may close these issues.
4 participants
@silviodonato @cmsbuild @Martin-Grunewald @davidlange6