Make the static zeroSample const

[Dr15Jones]

The static analyzer was complaining about the static zeroSample
being non-const. Since it is never modified we now make it const.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_X.

Make the static zeroSample const

It involves the following packages:

FastSimulation/CaloRecHitsProducer

@cmsbuild, @civanch, @nclopezo, @mdhildreth, @lveldere can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

[cmsbuild]

-1
Tested at: ba152e9
When I ran the RelVals I found an error in the following worklfows:
1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7188/1901/summary.html

[Dr15Jones]

The test failures are unrelated to this pull request.

[cmsbuild]

+1
Tested at: ba152e9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7188/1921/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7188/1921/summary.html

[cmsbuild]

+1
Tested at: ba152e9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7188/1929/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7188/1929/summary.html

[lveldere]

+1

thanks!

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.